content/browser/web_contents/web_contents_impl.cc - Issue 11773042: Allow embedders to provide a custom view for popup (select box) widgets,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11773042: Allow embedders to provide a custom view for popup (select box) widgets, (Closed) Base URL: http://src.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

===================================================================

--- content/browser/web_contents/web_contents_impl.cc (revision 176042)

+++ content/browser/web_contents/web_contents_impl.cc (working copy)

@@ -1386,8 +1386,10 @@

new RenderWidgetHostImpl(this, process, route_id);

created_widgets_.insert(widget_host);

- RenderWidgetHostViewPort* widget_view =

- RenderWidgetHostViewPort::CreateViewForWidget(widget_host);

+ RenderWidgetHostViewPort* widget_view = RenderWidgetHostViewPort::FromRWHV(

+ view_->CreateViewForPopupWidget(widget_host));

+ if (!widget_view)

+ return;

if (!is_fullscreen) {

// Popups should not get activated.

widget_view->SetPopupType(popup_type);

« no previous file with comments | « AUTHORS ('k') | content/browser/web_contents/web_contents_view_android.h » ('j') | no next file with comments »