Update other unittests to use newly added TestingBrowserProcess::GetGlobal().

Update other unittests to use newly added TestingBrowserProcess::GetGlobal().

R=jcivelli@chromium.org,rsesek@chromium.org,thestig@chromium.org
BUG=None
TEST=green tests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175189

[Dan Beam, 2013-01-04 01:08:46]

nothing drives adoption like doing it yourself, right?

[Dan Beam, 2013-01-04 01:09:33]

oh yeah, this depends on the other CL you reviewed today -
https://chromiumcodereview.appspot.com/11689004/

[Jay Civelli, 2013-01-04 01:17:35]

Nice change!

LGTM

Nit: few places I marked (and other I didn't) where code could be in 1 line
(less than 80 chars).

https://chromiumcodereview.appspot.com/11759019/diff/1/chrome/browser/profile...
File chrome/browser/profiles/profile_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/11759019/diff/1/chrome/browser/profile...
chrome/browser/profiles/profile_manager_unittest.cc:105: &io_thread_);
Would that fit on the previous line?

https://chromiumcodereview.appspot.com/11759019/diff/1/chrome/browser/profile...
chrome/browser/profiles/profile_manager_unittest.cc:122: NULL);
Would that fit on the previous line?

https://chromiumcodereview.appspot.com/11759019/diff/1/chrome/browser/profile...
chrome/browser/profiles/profile_manager_unittest.cc:231: NULL);
Would that fit on the previous line?

[Dan Beam, 2013-01-04 01:26:50]

still waiting on the dependent CL (and the rebase it'll require)

https://chromiumcodereview.appspot.com/11759019/diff/1/chrome/browser/profile...
File chrome/browser/profiles/profile_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/11759019/diff/1/chrome/browser/profile...
chrome/browser/profiles/profile_manager_unittest.cc:105: &io_thread_);
On 2013/01/04 01:17:35, Jay Civelli wrote:
> Would that fit on the previous line?

Done.

https://chromiumcodereview.appspot.com/11759019/diff/1/chrome/browser/profile...
chrome/browser/profiles/profile_manager_unittest.cc:122: NULL);
On 2013/01/04 01:17:35, Jay Civelli wrote:
> Would that fit on the previous line?

Done.

https://chromiumcodereview.appspot.com/11759019/diff/1/chrome/browser/profile...
chrome/browser/profiles/profile_manager_unittest.cc:231: NULL);
On 2013/01/04 01:17:35, Jay Civelli wrote:
> Would that fit on the previous line?

Done.

[Dan Beam, 2013-01-04 01:48:44]

so I just moved the stuff I did in another CL here so it could be done in
parallel / try jobs work, I'll let rsesek@ look at this before I commit

[Robert Sesek, 2013-01-04 17:11:03]

Nice cleanup. LGTM.

[commit-bot: I haz the power, 2013-01-04 18:00:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11759019/16001

[commit-bot: I haz the power, 2013-01-04 18:00:30]

Presubmit check for 11759019-16001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/autocomplete
    chrome/browser/printing/cloud_print
    chrome/browser/chromeos/cros
    chrome/browser/policy
    chrome/browser/chromeos/login
    chrome/browser/ui/sync
    chrome/browser/profiles
    chrome/browser/signin
    chrome/browser/extensions
    chrome/browser/ui/tab_contents
    chrome/browser/chromeos
    chrome/browser/history
    chrome/browser/chromeos/contacts
    chrome/browser/chromeos/input_method
    chrome/browser/ui
    chrome/browser/chromeos/settings
    chrome/browser/background
    chrome/browser/browsing_data
    chrome/browser/chromeos/display

Presubmit checks took 6.1s to calculate.

[Dan Beam, 2013-01-04 18:04:09]

+thestig@ for chrome/browser/OWNERS

[James Hawkins, 2013-01-04 18:31:11]

lgtm

[commit-bot: I haz the power, 2013-01-04 18:42:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/11759019/7003

[commit-bot: I haz the power, 2013-01-04 20:41:26]

Change committed as 175189