chrome/browser/web_resource/promo_resource_service_unittest.cc - Issue 11759019: Update other unittests to use newly added TestingBrowserProcess::GetGlobal().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/promo_resource_service_unittest.cc

Issue 11759019: Update other unittests to use newly added TestingBrowserProcess::GetGlobal(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: simpler codez Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc ('k') | chrome/test/base/testing_browser_process.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_resource/promo_resource_service_unittest.cc

diff --git a/chrome/browser/web_resource/promo_resource_service_unittest.cc b/chrome/browser/web_resource/promo_resource_service_unittest.cc

index 71f5b28a988d8e0822101c696a8c2838a7de5779..98529d5a1d789ed90f2b1039aa1cf5c767bcb598 100644

--- a/chrome/browser/web_resource/promo_resource_service_unittest.cc

+++ b/chrome/browser/web_resource/promo_resource_service_unittest.cc

@@ -27,13 +27,10 @@

class PromoResourceServiceTest : public testing::Test {

public:

+ // |promo_resource_service_| must be created after |local_state_|.

PromoResourceServiceTest()

- : local_state_(static_cast<TestingBrowserProcess*>(g_browser_process)) {

- static_cast<TestingBrowserProcess*>(g_browser_process)->SetLocalState(

- local_state_.Get());

- // |promo_resource_service_| must be created after local state is set.

- promo_resource_service_ = new PromoResourceService;

- }

+ : local_state_(TestingBrowserProcess::GetGlobal()),

+ promo_resource_service_(new PromoResourceService) {}

protected:

ScopedTestingLocalState local_state_;

@@ -53,8 +50,7 @@ class NotificationPromoTest {

time_slice_(0),

max_group_(0),

max_views_(0),

- closed_(false) {

- }

+ closed_(false) {}

void Init(const std::string& json,

const std::string& promo_text,