Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 11759008: Introduce ENABLE_LATIN_1 compile flag (Closed)

Created:
7 years, 11 months ago by drcarney
Modified:
7 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Introduce ENABLE_LATIN_1 compile flag Mostly a bunch of renaming when flag is disabled. R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13340

Patch Set 1 #

Patch Set 2 : Fixed a few sign extension bugs #

Patch Set 3 : a bunch of sign conversions #

Total comments: 7

Patch Set 4 : Fix FilterASCII #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -242 lines) Patch
M build/common.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ast.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/bootstrapper.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/codegen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.h View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M src/factory.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/heap.h View 1 2 3 chunks +15 lines, -7 lines 0 comments Download
M src/heap.cc View 1 2 14 chunks +29 lines, -28 lines 0 comments Download
M src/heap-inl.h View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/json-parser.h View 1 2 5 chunks +7 lines, -6 lines 0 comments Download
M src/jsregexp.h View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M src/jsregexp.cc View 1 2 3 23 chunks +73 lines, -39 lines 0 comments Download
M src/log.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 12 chunks +37 lines, -13 lines 0 comments Download
M src/objects.cc View 1 2 8 chunks +21 lines, -19 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 chunks +11 lines, -1 line 0 comments Download
M src/parser.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 2 13 chunks +18 lines, -14 lines 0 comments Download
M src/scanner.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/string.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/string-search.h View 4 chunks +7 lines, -6 lines 0 comments Download
M src/unicode.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/utils.h View 1 2 3 chunks +40 lines, -2 lines 0 comments Download
M src/v8utils.h View 1 2 1 chunk +32 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-hashing.cc View 1 2 6 chunks +14 lines, -9 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-latin-1.js View 1 2 3 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Some comments - A lot of the changes from kMaxAsciiCode to kMaxOneByteCode are not gated ...
7 years, 11 months ago (2013-01-07 16:15:07 UTC) #1
drcarney
I think this takes care of the FilterASCII problem to start. I'm planning to do ...
7 years, 11 months ago (2013-01-08 15:06:31 UTC) #2
Yang
7 years, 11 months ago (2013-01-09 10:30:42 UTC) #3
On 2013/01/08 15:06:31, dcarney wrote:
> I think this takes care of the FilterASCII problem to start.
> 
> I'm planning to do a series of mass renames to do with the ascii/one byte
naming
> problem after there's some stability.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698