Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 11758002: Desktop aura: Expand what the ViewsDelegate can do to new windows. (Closed)

Created:
7 years, 11 months ago by Elliot Glaysher
Modified:
7 years, 11 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Desktop aura: Expand what the ViewsDelegate can do to new windows. (This is a reland of r173539, adding early bails to some implementations of OnBeforeWidgetInit so that we don't clobber an already set Widget::InitParams::native_widget.) There are actual cases where we have to show dialogs with no parent or context, when there are no browser windows. All of the cases that I can find go through the CreateWindow() interface. CreateWindow() now explicitly sets InitParams::top_level to true. The ViewsDelegate now can do arbitrary manipulations on the InitParams so that when top_level is true and we have no context, we either create a native_widget or set the context based on desktop type. BUG=165759 TBR=ben@chromium.org (who did the original review) First Review URL: https://chromiumcodereview.appspot.com/11578014 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175131

Patch Set 1 #

Patch Set 2 : Don't clobber native_widget #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -72 lines) Patch
M chrome/browser/ui/views/chrome_views_delegate.h View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 2 chunks +44 lines, -14 lines 0 comments Download
M ui/views/test/desktop_test_views_delegate.h View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/views/test/desktop_test_views_delegate.cc View 1 1 chunk +13 lines, -12 lines 0 comments Download
M ui/views/test/test_views_delegate.h View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M ui/views/views_delegate.h View 1 chunk +3 lines, -7 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 4 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/11758002/6002
7 years, 11 months ago (2013-01-03 22:27:24 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests
7 years, 11 months ago (2013-01-04 01:05:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/11758002/6002
7 years, 11 months ago (2013-01-04 07:57:38 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 12:17:21 UTC) #4
Message was sent while issue was closed.
Change committed as 175131

Powered by Google App Engine
This is Rietveld 408576698