Desktop aura: Expand what the ViewsDelegate can do to new windows.

Desktop aura: Expand what the ViewsDelegate can do to new windows.

There are actual cases where we have to show dialogs with no parent or context,
when there are no browser windows. All of the cases that I can find go through
the CreateWindow() interface.

CreateWindow() now explicitly sets InitParams::top_level to true. The
ViewsDelegate now can do arbitrary manipulations on the InitParams so that when
top_level is true and we have no context, we either create a native_widget or
set the context based on desktop type.

BUG=165759
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173539

[Elliot Glaysher, 2012-12-13 23:19:32]

While 90% of the time that there isn't parent or context is laziness, the rest
are legitimate cases.

Robert, is the implementation in ChromeViewsDelegate closer to what you were
talking about yesterday, when you said that we could grab the active desktop
type?

[Ben Goodger (Google), 2012-12-13 23:47:41]

lgtm

https://codereview.chromium.org/11578014/diff/1/chrome/browser/ui/views/chrom...
File chrome/browser/ui/views/chrome_views_delegate.cc (right):

https://codereview.chromium.org/11578014/diff/1/chrome/browser/ui/views/chrom...
chrome/browser/ui/views/chrome_views_delegate.cc:186: params->top_level == true)
{
params->top_level

https://codereview.chromium.org/11578014/diff/1/chrome/browser/ui/views/chrom...
chrome/browser/ui/views/chrome_views_delegate.cc:190: case
chrome::HOST_DESKTOP_TYPE_NATIVE: {
you don't need the braces on each case since you're not declaring any locals.

https://codereview.chromium.org/11578014/diff/1/ui/views/widget/widget.cc
File ui/views/widget/widget.cc (right):

https://codereview.chromium.org/11578014/diff/1/ui/views/widget/widget.cc#new...
ui/views/widget/widget.cc:336:
ViewsDelegate::views_delegate->OnWidgetInit(&params, this);
OnBeforeWidgetInit perhaps. OnInit makes it sound like a notification that it
was init (at least convention would indicate that).

[robertshield, 2012-12-14 01:15:58]

Yep, that's what I meant :)

LGTM

https://codereview.chromium.org/11578014/diff/1/chrome/browser/ui/views/chrom...
File chrome/browser/ui/views/chrome_views_delegate.cc (right):

https://codereview.chromium.org/11578014/diff/1/chrome/browser/ui/views/chrom...
chrome/browser/ui/views/chrome_views_delegate.cc:197: #if defined(USE_ASH)
How about moving the #if to completely surround the case statement, so that we
fall through to the NOTREACHED if we get HOST_DESKTOP_TYPE_ASH when USE_ASH is
not defined?

https://codereview.chromium.org/11578014/diff/1/ui/views/widget/widget.h
File ui/views/widget/widget.h (right):

https://codereview.chromium.org/11578014/diff/1/ui/views/widget/widget.h#newc...
ui/views/widget/widget.h:191: // attachment to any other window.
I initially found it confusing that a Widget can be top-level but may still have
a non-NULL |parent|. Could you mention that here?

[commit-bot: I haz the power, 2012-12-14 20:56:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/11578014/2003

[commit-bot: I haz the power, 2012-12-15 00:51:31]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-17 18:24:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/11578014/16001

[commit-bot: I haz the power, 2012-12-17 21:45:25]

Change committed as 173539