Remove Android only warnings

Remove Android only warnings


BUG=b/7719282


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175067

[Torne, 2013-01-03 15:56:01]

LGTM, thanks for this!

[commit-bot: I haz the power, 2013-01-03 18:46:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kristianm@chromium.org/11746004/2001

[joth, 2013-01-03 18:50:06]

lgtm - just comment nits

https://chromiumcodereview.appspot.com/11746004/diff/2001/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11746004/diff/2001/build/common.gypi#n...
build/common.gypi:3056: # Disable warnings enabled by the Android build system
nit: flesh this out to:
Disable any additional warnings enabled by the Android build system but which
chromium does not build cleanly with (when treating warning as errors).

https://chromiumcodereview.appspot.com/11746004/diff/2001/build/common.gypi#n...
build/common.gypi:3079: # them from being treated as errors here.
what about these? Drop the -error= from these too?
Possibly the comment could be reworded too (e.g. drop "for now", refer to the
section above).

Also non-virtual-dtor presumably not needed here as it's in the list above ?

[Kristian Monsen, 2013-01-03 20:10:18]

https://chromiumcodereview.appspot.com/11746004/diff/2001/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11746004/diff/2001/build/common.gypi#n...
build/common.gypi:3056: # Disable warnings enabled by the Android build system
On 2013/01/03 18:50:06, joth wrote:
> nit: flesh this out to:
> Disable any additional warnings enabled by the Android build system but which
> chromium does not build cleanly with (when treating warning as errors).

Done.

https://chromiumcodereview.appspot.com/11746004/diff/2001/build/common.gypi#n...
build/common.gypi:3079: # them from being treated as errors here.
On 2013/01/03 18:50:06, joth wrote:
> what about these? Drop the -error= from these too?
> Possibly the comment could be reworded too (e.g. drop "for now", refer to the
> section above).
> 
> Also non-virtual-dtor presumably not needed here as it's in the list above ?

I think they are separate. These weren't really an issue for me as it is third
party code.

Updated to remove warnings here as well.

[commit-bot: I haz the power, 2013-01-03 20:58:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kristianm@chromium.org/11746004/13001

[commit-bot: I haz the power, 2013-01-03 22:00:03]

Retried try job too often on win_rel for step(s) chrome_frame_net_tests,
sync_integration_tests

[commit-bot: I haz the power, 2013-01-03 22:02:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kristianm@chromium.org/11746004/13001

[commit-bot: I haz the power, 2013-01-04 00:48:59]

Change committed as 175067