Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: build/common.gypi

Issue 11746004: Remove Android only warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated comment Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3035 matching lines...) Expand 10 before | Expand all | Expand 10 after
3046 'include_dirs': [ 3046 'include_dirs': [
3047 # OpenAL headers from the Android tree. 3047 # OpenAL headers from the Android tree.
3048 '<(android_src)/frameworks/wilhelm/include', 3048 '<(android_src)/frameworks/wilhelm/include',
3049 ], 3049 ],
3050 'cflags': [ 3050 'cflags': [
3051 # Android predefines this as 1; undefine it here so Chromium 3051 # Android predefines this as 1; undefine it here so Chromium
3052 # can redefine it later to be 2 for chromium code and unset 3052 # can redefine it later to be 2 for chromium code and unset
3053 # for third party code. This works because cflags are added 3053 # for third party code. This works because cflags are added
3054 # before defines. 3054 # before defines.
3055 '-U_FORTIFY_SOURCE', 3055 '-U_FORTIFY_SOURCE',
3056 # Chromium builds its own (non-third-party) code with 3056 # Disable warnings enabled by the Android build system
joth 2013/01/03 18:50:06 nit: flesh this out to: Disable any additional war
Kristian Monsen 2013/01/03 20:10:18 Done.
3057 # -Werror to make all warnings into errors. However, Android
3058 # enables warnings that Chromium doesn't, so some of these
3059 # extra warnings trip and break things.
3060 # For now, we leave these warnings enabled but prevent them
3061 # from being treated as errors.
3062 #
3063 # Things that are part of -Wextra: 3057 # Things that are part of -Wextra:
3064 '-Wno-error=extra', # Enabled by -Wextra, but no specific flag 3058 '-Wno-extra', # Enabled by -Wextra, but no specific flag
3065 '-Wno-error=ignored-qualifiers', 3059 '-Wno-ignored-qualifiers',
3066 '-Wno-error=type-limits', 3060 '-Wno-type-limits',
3067 # Other things unrelated to -Wextra: 3061 # Other things unrelated to -Wextra:
3068 '-Wno-error=non-virtual-dtor', 3062 '-Wno-non-virtual-dtor',
3069 '-Wno-error=sign-promo', 3063 '-Wno-sign-promo',
3070 ], 3064 ],
3071 'cflags_cc': [ 3065 'cflags_cc': [
3072 # Disabling c++0x-compat should be handled in WebKit, but 3066 # Disabling c++0x-compat should be handled in WebKit, but
3073 # this currently doesn't work because gcc_version is not set 3067 # this currently doesn't work because gcc_version is not set
3074 # correctly when building with the Android build system. 3068 # correctly when building with the Android build system.
3075 # TODO(torne): Fix this in WebKit. 3069 # TODO(torne): Fix this in WebKit.
3076 '-Wno-error=c++0x-compat', 3070 '-Wno-error=c++0x-compat',
3077 ], 3071 ],
3078 }], 3072 }],
3079 ['android_build_type==1 and chromium_code==0', { 3073 ['android_build_type==1 and chromium_code==0', {
3080 'cflags': [ 3074 'cflags': [
3081 # There is a class of warning which: 3075 # There is a class of warning which:
3082 # 1) Android always enables and also treats as errors 3076 # 1) Android always enables and also treats as errors
3083 # 2) Chromium ignores in third party code 3077 # 2) Chromium ignores in third party code
3084 # For now, I am leaving these warnings enabled but preventing 3078 # For now, I am leaving these warnings enabled but preventing
3085 # them from being treated as errors here. 3079 # them from being treated as errors here.
joth 2013/01/03 18:50:06 what about these? Drop the -error= from these too?
Kristian Monsen 2013/01/03 20:10:18 I think they are separate. These weren't really an
3086 '-Wno-error=address', 3080 '-Wno-error=address',
3087 '-Wno-error=format-security', 3081 '-Wno-error=format-security',
3088 '-Wno-error=non-virtual-dtor', 3082 '-Wno-error=non-virtual-dtor',
3089 '-Wno-error=return-type', 3083 '-Wno-error=return-type',
3090 '-Wno-error=sequence-point', 3084 '-Wno-error=sequence-point',
3091 ], 3085 ],
3092 }], 3086 }],
3093 ['target_arch == "arm"', { 3087 ['target_arch == "arm"', {
3094 'ldflags': [ 3088 'ldflags': [
3095 # Enable identical code folding to reduce size. 3089 # Enable identical code folding to reduce size.
(...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after
3951 # settings in target dicts. SYMROOT is a special case, because many other 3945 # settings in target dicts. SYMROOT is a special case, because many other
3952 # Xcode variables depend on it, including variables such as 3946 # Xcode variables depend on it, including variables such as
3953 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 3947 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
3954 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 3948 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
3955 # files to appear (when present) in the UI as actual files and not red 3949 # files to appear (when present) in the UI as actual files and not red
3956 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 3950 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
3957 # and therefore SYMROOT, needs to be set at the project level. 3951 # and therefore SYMROOT, needs to be set at the project level.
3958 'SYMROOT': '<(DEPTH)/xcodebuild', 3952 'SYMROOT': '<(DEPTH)/xcodebuild',
3959 }, 3953 },
3960 } 3954 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698