Windows: Remove desktop profile shortcuts (and any others pointing to the exe) on uninstall.

Windows: Remove desktop profile shortcuts (and any others pointing to the exe) on uninstall. 

This is a re-land of https://codereview.chromium.org/11693010/, which failed on the tree on XP bots. The issue was that ProgramCompare::Evaluate() was parsing its value parameter is a command-line, which meant it was truncating it at the first space. This updated CL adds an EvaluatePath() function that takes a FilePath and doesn't try to parse it as a command-line. 

BUG=146636
TEST=Uninstalling Chrome removes any present profile shortcuts on the desktop.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175104

[gab, 2013-01-03 18:45:56]

On 2013/01/03 18:12:10, Alexei Svitkine wrote:

Can you make patch set 1 the old CL so it's easier to see the diff?

Thanks,
Gab

[Alexei Svitkine (slow), 2013-01-03 18:55:06]

done

[gab, 2013-01-03 19:19:25]

Arg... I had the exact same change in my pipeline, but was waiting for this
change to come in so I could also change the Evaluate you were moving in this
change without conflicting...

lgtm, but please also change the one I highlighted below.

https://codereview.chromium.org/11743022/diff/2005/chrome/installer/util/shel...
File chrome/installer/util/shell_util.cc (right):

https://codereview.chromium.org/11743022/diff/2005/chrome/installer/util/shel...
chrome/installer/util/shell_util.cc:1888: if
(target_compare.Evaluate(read_target.value())) {
Please change this one as well.

[Alexei Svitkine (slow), 2013-01-03 19:40:00]

https://codereview.chromium.org/11743022/diff/2005/chrome/installer/util/shel...
File chrome/installer/util/shell_util.cc (right):

https://codereview.chromium.org/11743022/diff/2005/chrome/installer/util/shel...
chrome/installer/util/shell_util.cc:1888: if
(target_compare.Evaluate(read_target.value())) {
On 2013/01/03 19:19:25, gab wrote:
> Please change this one as well.

Done.

[Alexei Svitkine (slow), 2013-01-03 19:40:22]

brettw: Could I get another OWNERS rubber-stamp?

[Alexei Svitkine (slow), 2013-01-03 20:07:25]

TBR'ing brettw since the chrome/ parts didn't change since the last review.

[commit-bot: I haz the power, 2013-01-03 20:08:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11743022/11003

[brettw, 2013-01-03 20:09:49]

lgtm rubberstamp

[commit-bot: I haz the power, 2013-01-03 20:11:56]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-03 20:15:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11743022/11003

[commit-bot: I haz the power, 2013-01-03 23:25:30]

Retried try job too often on win_rel for step(s) sync_integration_tests

[commit-bot: I haz the power, 2013-01-04 03:42:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11743022/11003

[commit-bot: I haz the power, 2013-01-04 04:49:51]

Change committed as 175104