Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 11743022: Windows: Remove desktop profile shortcuts (and any others pointing to the exe) on uninstall. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_shortcut_manager_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main_win.cc
===================================================================
--- chrome/browser/chrome_browser_main_win.cc (revision 174984)
+++ chrome/browser/chrome_browser_main_win.cc (working copy)
@@ -135,9 +135,6 @@
VLOG(1) << "Executing uninstall actions";
if (!first_run::RemoveSentinel())
VLOG(1) << "Failed to delete sentinel file.";
- // We want to remove user level shortcuts and we only care about the ones
- // created by us and not by the installer so |alternate| is false.
- BrowserDistribution* dist = BrowserDistribution::GetDistribution();
FilePath chrome_exe;
if (PathService::Get(base::FILE_EXE, &chrome_exe)) {
ShellUtil::ShortcutLocation user_shortcut_locations[] = {
@@ -145,15 +142,15 @@
ShellUtil::SHORTCUT_LOCATION_QUICK_LAUNCH,
ShellUtil::SHORTCUT_LOCATION_START_MENU,
};
+ BrowserDistribution* dist = BrowserDistribution::GetDistribution();
for (size_t i = 0; i < arraysize(user_shortcut_locations); ++i) {
- if (!ShellUtil::RemoveShortcut(
- user_shortcut_locations[i], dist, chrome_exe.value(),
- ShellUtil::CURRENT_USER, NULL)) {
+ if (!ShellUtil::RemoveShortcut(user_shortcut_locations[i], dist,
+ chrome_exe, ShellUtil::CURRENT_USER,
+ NULL)) {
VLOG(1) << "Failed to delete shortcut at location "
<< user_shortcut_locations[i];
}
}
- // TODO(rlp): Cleanup profiles shortcuts.
} else {
NOTREACHED();
}
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_shortcut_manager_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698