Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: content/browser/download/download_item_impl_delegate.h

Issue 11740026: Pull delegate check back into IsDownloadReadyForCompletion so that if (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed test. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl_delegate.h
diff --git a/content/browser/download/download_item_impl_delegate.h b/content/browser/download/download_item_impl_delegate.h
index be6f890f489257f383bc9e873ae3246e710547f5..c1c59b0521c6db0c7879dff88f759d0a578b8cce 100644
--- a/content/browser/download/download_item_impl_delegate.h
+++ b/content/browser/download/download_item_impl_delegate.h
@@ -44,11 +44,10 @@ class CONTENT_EXPORT DownloadItemImplDelegate {
DownloadItemImpl* download, const DownloadTargetCallback& callback);
// Allows the delegate to delay completion of the download. This function
- // will call the callback passed when the download is ready for completion.
- // This may be done immediately, from within the routine itself, or it
- // may be delayed.
- // This routine should only be called once per download.
- virtual void ReadyForDownloadCompletion(
+ // will either return true (if the download may complete now) or will return
+ // false and call the provided callback at some future point. This function
+ // may be called repeatedly.
+ virtual bool ShouldCompleteDownload(
DownloadItemImpl* download,
const base::Closure& complete_callback);
« no previous file with comments | « content/browser/download/download_item_impl.cc ('k') | content/browser/download/download_item_impl_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698