Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: chrome/test/functional/perf.py

Issue 11740020: [telemetry] Removing globals from webpagereplay.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/devtools_test_base.py ('k') | chrome/test/functional/perf_endure.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/perf.py
diff --git a/chrome/test/functional/perf.py b/chrome/test/functional/perf.py
index f82c7090c03bc708124c02736668346823d5a312..df8caad320d9106d41f58daa51f6ea21b2d55c47 100755
--- a/chrome/test/functional/perf.py
+++ b/chrome/test/functional/perf.py
@@ -2286,17 +2286,24 @@ class PageCyclerReplay(object):
'extension': 'src/tools/page_cycler/webpagereplay/extension',
}
- CHROME_FLAGS = webpagereplay.CHROME_FLAGS + [
- '--log-level=0',
- '--disable-background-networking',
- '--enable-experimental-extension-apis',
- '--enable-logging',
- '--enable-benchmarking',
- '--metrics-recording-only',
- '--activate-on-launch',
- '--no-first-run',
- '--no-proxy-server',
- ]
+ WEBPAGEREPLAY_HOST = '127.0.0.1'
+ WEBPAGEREPLAY_HTTP_PORT = 8080
+ WEBPAGEREPLAY_HTTPS_PORT = 8413
+
+ CHROME_FLAGS = webpagereplay.GetChromeFlags(
+ self.WEBPAGEREPLAY_HOST,
+ self.WEBPAGEREPLAY_HTTP_PORT,
+ self.WEBPAGEREPLAY_HTTPS_PORT) + [
+ '--log-level=0',
+ '--disable-background-networking',
+ '--enable-experimental-extension-apis',
+ '--enable-logging',
+ '--enable-benchmarking',
+ '--metrics-recording-only',
+ '--activate-on-launch',
+ '--no-first-run',
+ '--no-proxy-server',
+ ]
@classmethod
def Path(cls, key, **kwargs):
@@ -2305,7 +2312,11 @@ class PageCyclerReplay(object):
@classmethod
def ReplayServer(cls, test_name, replay_options=None):
archive_path = cls.Path('archive', test_name=test_name)
- return webpagereplay.ReplayServer(archive_path, replay_options)
+ return webpagereplay.ReplayServer(archive_path,
+ self.WEBPAGEREPLAY_HOST,
+ self.WEBPAGEREPLAY_HTTP_PORT,
+ self.WEBPAGEREPLAY_HTTPS_PORT,
+ replay_options)
class PageCyclerNetSimTest(BasePageCyclerTest):
« no previous file with comments | « chrome/test/functional/devtools_test_base.py ('k') | chrome/test/functional/perf_endure.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698