Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6985)

Unified Diff: chrome/test/functional/perf_endure.py

Issue 11740020: [telemetry] Removing globals from webpagereplay.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/perf.py ('k') | chrome/test/functional/webpagereplay.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/perf_endure.py
diff --git a/chrome/test/functional/perf_endure.py b/chrome/test/functional/perf_endure.py
index c45c0df04bbc926eda5b6082f0847432b0521ebf..b3518310c2a93c06bd1a5804da2c07c3f7d1361c 100755
--- a/chrome/test/functional/perf_endure.py
+++ b/chrome/test/functional/perf_endure.py
@@ -1287,7 +1287,15 @@ class ChromeEndureReplay(object):
'scripts':
'src/chrome/test/data/chrome_endure/webpagereplay/wpr_deterministic.js',
}
- CHROME_FLAGS = webpagereplay.CHROME_FLAGS
+
+ WEBPAGEREPLAY_HOST = '127.0.0.1'
+ WEBPAGEREPLAY_HTTP_PORT = 8080
+ WEBPAGEREPLAY_HTTPS_PORT = 8413
+
+ CHROME_FLAGS = webpagereplay.GetChromeFlags(
+ self.WEBPAGEREPLAY_HOST,
+ self.WEBPAGEREPLAY_HTTP_PORT,
+ self.WEBPAGEREPLAY_HTTPS_PORT)
@classmethod
def Path(cls, key, **kwargs):
@@ -1304,7 +1312,11 @@ class ChromeEndureReplay(object):
replay_options = ['--inject_scripts', scripts]
if 'WPR_RECORD' in os.environ:
replay_options.append('--append')
- return webpagereplay.ReplayServer(archive_path, replay_options)
+ return webpagereplay.ReplayServer(archive_path,
+ self.WEBPAGEREPLAY_HOST,
+ self.WEBPAGEREPLAY_HTTP_PORT,
+ self.WEBPAGEREPLAY_HTTPS_PORT,
+ replay_options)
if __name__ == '__main__':
« no previous file with comments | « chrome/test/functional/perf.py ('k') | chrome/test/functional/webpagereplay.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698