Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 11737038: Fix proxy settings so that a port number in the host field gets applied to the port field. (Closed)

Created:
7 years, 11 months ago by Greg Spencer (Chromium)
Modified:
7 years, 11 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, marvinding_linpus.com, warrencoles_linpus.com
Visibility:
Public.

Description

Fix proxy settings so that a port number in the host field gets applied to the port field. chrome/browser/chromeos/proxy_cros_settings_parser.cc:85 The port number's final value comes from either the one specified in the Host field or the one specified in the Port field. Which one it would be depends on which field is the last updated field, so the overriding-it-whatever logic will be no longer necessary, and we removed it. chrome/browser/resources/options/chromeos/internet_detail.js:524 Add a new function called "updateProxySetting", it is used to update the proxy setting dialog's UI. Whenever the internal data storing the proxy information is changed, this function is called to update the UI instantly. chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc:167 When the proxy data settings changed, make sure the view is updated properly by calling JS function - updateProxySettings. This patch was contributed by keenepan@linpus.com, and originally reviewed in CL TBR=pastarmovj@chromium.org BUG=chromium-os:26554 TEST=Setting manual proxy with "http://" prefix AND ":<port>" suffix, the proxy settings dialog UI will update and values will in right TEXTVIEW Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/proxy_cros_settings_parser.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.js View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/11737038/1
7 years, 11 months ago (2013-01-04 19:14:45 UTC) #1
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 22:26:50 UTC) #2
Message was sent while issue was closed.
Change committed as 175213

Powered by Google App Engine
This is Rietveld 408576698