Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Unified Diff: chrome/browser/chromeos/proxy_cros_settings_parser.cc

Issue 11737038: Fix proxy settings so that a port number in the host field gets applied to the port field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | chrome/browser/resources/options/chromeos/internet_detail.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/proxy_cros_settings_parser.cc
diff --git a/chrome/browser/chromeos/proxy_cros_settings_parser.cc b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
index 5dc5e270340f4067c899d0ff9744933216606ce6..e902a5e0738f0bc3882ca7adc816b8ead8f9bde1 100644
--- a/chrome/browser/chromeos/proxy_cros_settings_parser.cc
+++ b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
@@ -82,10 +82,7 @@ net::ProxyServer CreateProxyServer(std::string host,
host_port_pair = net::HostPortPair::FromString(host);
if (host_port_pair.host().empty()) // Host is not URL or <server>::<port>.
host_port_pair = net::HostPortPair(host, port);
- // Formal parameter port overrides what may have been specified in host.
- if (port != 0 && port != default_port)
- host_port_pair.set_port(port);
- else if (host_port_pair.port() == 0) // No port in host, use default.
+ if (host_port_pair.port() == 0) // No port in host, use default.
host_port_pair.set_port(default_port);
return net::ProxyServer(scheme, host_port_pair);
}
« no previous file with comments | « AUTHORS ('k') | chrome/browser/resources/options/chromeos/internet_detail.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698