Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7637)

Unified Diff: chrome/common/extensions/extension.h

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse
Patch Set: fixed HomepageURLManifestTest.GetHomepageURL Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 12c128939db5ac0aaa66856d647f37b2cf229bd6..ea6430620ba5f52d39141417ca675194453c9721 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -683,7 +683,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool has_lazy_background_page() const {
return has_background_page() && !background_page_is_persistent_;
}
- const GURL& options_url() const { return options_url_; }
const GURL& details_url() const { return details_url_;}
const PermissionSet* optional_permission_set() const {
return optional_permission_set_.get();
@@ -696,7 +695,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const InstallWarningVector& install_warnings() const {
return install_warnings_;
}
- const GURL& update_url() const { return update_url_; }
const ExtensionIconSet& icons() const { return icons_; }
const extensions::Manifest* manifest() const {
return manifest_.get();
@@ -836,7 +834,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
string16* error);
bool LoadDescription(string16* error);
bool LoadManifestVersion(string16* error);
- bool LoadUpdateURL(string16* error);
bool LoadIcons(string16* error);
bool LoadCommands(string16* error);
bool LoadPlugins(string16* error);
@@ -847,7 +844,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadRequirements(string16* error);
bool LoadDefaultLocale(string16* error);
bool LoadOfflineEnabled(string16* error);
- bool LoadOptionsPage(string16* error);
bool LoadBackgroundScripts(string16* error);
bool LoadBackgroundScripts(const std::string& key, string16* error);
bool LoadBackgroundPage(const APIPermissionSet& api_permissions,
@@ -1075,9 +1071,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// allowing them to run in different processes.
bool allow_background_js_access_;
- // Optional URL to a page for setting options/preferences.
- GURL options_url_;
-
// URL to the webstore page of the extension.
GURL details_url_;
@@ -1099,9 +1092,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// A file containing a list of sites for Managed Mode.
FilePath content_pack_site_list_;
- // URL for fetching an update manifest
- GURL update_url_;
-
// The manifest from which this extension was created.
scoped_ptr<Manifest> manifest_;
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698