chrome/browser/ui/webui/extensions/extension_settings_handler.cc - Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse

Patch Set: fixed HomepageURLManifestTest.GetHomepageURL Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

index 018d7e7f3e56693f4373fdcf2e53d5352cb17825..0c5b119878dc26afd52fa3c4530b77264fe21f76 100644

--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc

@@ -784,7 +784,8 @@ void ExtensionSettingsHandler::HandleUninstallMessage(const ListValue* args) {

void ExtensionSettingsHandler::HandleOptionsMessage(const ListValue* args) {

const Extension* extension = GetActiveExtension(args);

- if (!extension || extension->options_url().is_empty())

+ if (!extension ||

+ extensions::ManifestURL::GetOptionsPage(extension).is_empty())

return;

extensions::ExtensionSystem::Get(Profile::FromWebUI(web_ui()))->

process_manager()->OpenOptionsPage(extension,

« no previous file with comments | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »