Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: chrome/browser/extensions/extension_process_manager.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse
Patch Set: fixed HomepageURLManifestTest.GetHomepageURL Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_process_manager.cc
diff --git a/chrome/browser/extensions/extension_process_manager.cc b/chrome/browser/extensions/extension_process_manager.cc
index dc54dca25efd8a2b01bc50accc365c86d24dc423..8ef6ec134255123bd8c4adde42c97f062ff0a740 100644
--- a/chrome/browser/extensions/extension_process_manager.cc
+++ b/chrome/browser/extensions/extension_process_manager.cc
@@ -27,6 +27,7 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_messages.h"
+#include "chrome/common/extensions/manifest_url_handler.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
@@ -310,7 +311,7 @@ void ExtensionProcessManager::CreateBackgroundHost(
void ExtensionProcessManager::OpenOptionsPage(const Extension* extension,
Browser* browser) {
- DCHECK(!extension->options_url().is_empty());
+ DCHECK(!extensions::ManifestURL::GetOptionsPage(extension).is_empty());
// Force the options page to open in non-OTR window, because it won't be
// able to save settings from OTR.
@@ -320,7 +321,8 @@ void ExtensionProcessManager::OpenOptionsPage(const Extension* extension,
browser->host_desktop_type());
}
- OpenURLParams params(extension->options_url(), Referrer(), SINGLETON_TAB,
+ OpenURLParams params(extensions::ManifestURL::GetOptionsPage(extension),
+ Referrer(), SINGLETON_TAB,
content::PAGE_TRANSITION_LINK, false);
browser->OpenURL(params);
browser->window()->Show();
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.h ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698