chrome/browser/extensions/extension_service.cc - Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse

Patch Set: fixed HomepageURLManifestTest.GetHomepageURL Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 97579754954a4652f71ee5ce2b094df91c8a3368..2af5075d151db0a41ac28b4b5b92048a18d6fcb2 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -89,6 +89,7 @@

#include "chrome/common/extensions/feature_switch.h"

#include "chrome/common/extensions/features/feature.h"

#include "chrome/common/extensions/manifest.h"

+#include "chrome/common/extensions/manifest_url_handler.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/browser_thread.h"

@@ -2344,7 +2345,8 @@ void ExtensionService::OnExtensionInstalled(

LOG(WARNING) << "ShouldAllowInstall() returned false for "

<< id << " of type " << extension->GetType()

- << " and update URL " << extension->update_url().spec()

+ << " and update URL "

+ << extensions::ManifestURL::GetUpdateURL(extension).spec()

<< "; not installing";

content::NotificationService::current()->Notify(

« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »