Issue 11719004: Remove Profile-keyed factory boilerplate: cookies, managed_mode & web_navigation

Issue 11719004: Remove Profile-keyed factory boilerplate: cookies, managed_mode & web_navigation (Closed)

Created:
7 years, 11 months ago by Joe Thomas

Modified:
7 years, 11 months ago

Reviewers:
Yoyo Zhou, sail, Ben Goodger (Google), Ryan Sleevi

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove Profile-keyed factory boilerplate: cookies, managed_mode & web_navigation Patch from Joe Thomas <mhx348@motorola.com>;. BUG=159265 TBR=ben@chromium.org for gyp Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174918

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -241 lines)			Patch
M	chrome/browser/extensions/api/cookies/cookies_api.h	View	3 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/cookies/cookies_api.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
D	chrome/browser/extensions/api/cookies/cookies_api_factory.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/extensions/api/cookies/cookies_api_factory.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/extensions/api/managed_mode/managed_mode_api.h	View	3 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/managed_mode/managed_mode_api.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
D	chrome/browser/extensions/api/managed_mode/managed_mode_api_factory.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/extensions/api/managed_mode/managed_mode_api_factory.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.h	View	3 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
D	chrome/browser/extensions/api/web_navigation/web_navigation_api_factory.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/extensions/api/web_navigation/web_navigation_api_factory.cc	View	1 chunk	+0 lines, -40 lines	0 comments	Download
M	chrome/browser/profiles/profile_dependency_manager.cc	View	4 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	3 chunks	+1 line, -8 lines	1 comment	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/MHX348@motorola.com/11719004/1

7 years, 11 months ago (2013-01-02 23:20:48 UTC) #4

Ryan Sleevi

Please clean up the style issue below in a (new) CL. https://chromiumcodereview.appspot.com/11719004/diff/1/chrome/chrome_browser_extensions.gypi File chrome/chrome_browser_extensions.gypi (right): ...

7 years, 11 months ago (2013-01-03 03:13:36 UTC) #6

Joe Thomas

7 years, 11 months ago (2013-01-03 03:38:16 UTC) #7

Message was sent while issue was closed.

On 2013/01/03 03:13:36, Ryan Sleevi wrote:
> Please clean up the style issue below in a (new) CL.
> 
>
https://chromiumcodereview.appspot.com/11719004/diff/1/chrome/chrome_browser_...
> File chrome/chrome_browser_extensions.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/11719004/diff/1/chrome/chrome_browser_...
> chrome/chrome_browser_extensions.gypi:236:
> 'browser/extensions/api/managed_mode/managed_mode_api.h',       
> 'browser/extensions/api/management/management_api.cc',
> STYLE: You failed to properly add a newline here.

Sure, I will do it. Sorry for the mistake.

Thanks.

Expand Messages | Collapse Messages