Issue 11688006: Make modp_b64 and base::base64 compile on Win64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11688006: Make modp_b64 and base::base64 compile on Win64 (Closed)

Created:
7 years, 12 months ago by jschuh

Modified:
7 years, 12 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -31 lines)			Patch
M	base/base64.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	third_party/modp_b64/README.chromium	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/modp_b64/modp_b64.h	View	1	6 chunks	+9 lines, -5 lines	0 comments	Download
M	third_party/modp_b64/modp_b64.cc	View	1	11 chunks	+23 lines, -21 lines	0 comments	Download

Total messages: 4 (0 generated)

jschuh

The current usage is unsafe in 64-bit, so rather than just disable the warnings I ...

7 years, 12 months ago (2012-12-27 17:59:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/11688006/3004

7 years, 12 months ago (2012-12-27 19:20:57 UTC) #3

Message was sent while issue was closed.

Change committed as 174700