Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: base/base64.cc

Issue 11688006: Make modp_b64 and base::base64 compile on Win64 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | third_party/modp_b64/README.chromium » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/base64.h" 5 #include "base/base64.h"
6 6
7 #include "third_party/modp_b64/modp_b64.h" 7 #include "third_party/modp_b64/modp_b64.h"
8 8
9 namespace base { 9 namespace base {
10 10
11 bool Base64Encode(const StringPiece& input, std::string* output) { 11 bool Base64Encode(const StringPiece& input, std::string* output) {
12 std::string temp; 12 std::string temp;
13 temp.resize(modp_b64_encode_len(input.size())); // makes room for null byte 13 temp.resize(modp_b64_encode_len(input.size())); // makes room for null byte
14 14
15 // null terminates result since result is base64 text! 15 // null terminates result since result is base64 text!
16 int input_size = static_cast<int>(input.size()); 16 int input_size = static_cast<int>(input.size());
17 17
18 // modp_b64_encode_len() returns at least 1, so temp[0] is safe to use. 18 // modp_b64_encode_len() returns at least 1, so temp[0] is safe to use.
19 int output_size = modp_b64_encode(&(temp[0]), input.data(), input_size); 19 size_t output_size = modp_b64_encode(&(temp[0]), input.data(), input_size);
20 if (output_size < 0) 20 if (output_size == MODP_B64_ERROR)
21 return false; 21 return false;
22 22
23 temp.resize(output_size); // strips off null byte 23 temp.resize(output_size); // strips off null byte
24 output->swap(temp); 24 output->swap(temp);
25 return true; 25 return true;
26 } 26 }
27 27
28 bool Base64Decode(const StringPiece& input, std::string* output) { 28 bool Base64Decode(const StringPiece& input, std::string* output) {
29 std::string temp; 29 std::string temp;
30 temp.resize(modp_b64_decode_len(input.size())); 30 temp.resize(modp_b64_decode_len(input.size()));
31 31
32 // does not null terminate result since result is binary data! 32 // does not null terminate result since result is binary data!
33 int input_size = static_cast<int>(input.size()); 33 size_t input_size = input.size();
34 int output_size = modp_b64_decode(&(temp[0]), input.data(), input_size); 34 size_t output_size = modp_b64_decode(&(temp[0]), input.data(), input_size);
35 if (output_size < 0) 35 if (output_size == MODP_B64_ERROR)
36 return false; 36 return false;
37 37
38 temp.resize(output_size); 38 temp.resize(output_size);
39 output->swap(temp); 39 output->swap(temp);
40 return true; 40 return true;
41 } 41 }
42 42
43 } // namespace base 43 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | third_party/modp_b64/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698