Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: base/win/pe_image.cc

Issue 11684007: Remove 64-bit warning for pe_image (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/pe_image.cc
===================================================================
--- base/win/pe_image.cc (revision 174985)
+++ base/win/pe_image.cc (working copy)
@@ -11,11 +11,12 @@
namespace win {
#if defined(_WIN64) && !defined(NACL_WIN64)
-// TODO(rvargas): Bug 27218. Make sure this is ok.
-#error This code is not tested on x64. Please make sure all the base unit tests\
+// TODO(jschuh): crbug.com/167707 Make sure this is ok.
+#pragma message ("Warning: \
+ This code is not tested on x64. Please make sure all the base unit tests\
pass before doing any real work. The current unit tests don't test the\
differences between 32- and 64-bits implementations. Bugs may slip through.\
- You need to improve the coverage before continuing.
+ You need to improve the coverage before continuing.")
#endif
// Structure to perform imports enumerations.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698