Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Side by Side Diff: base/win/pe_image.cc

Issue 11684007: Remove 64-bit warning for pe_image (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file implements PEImage, a generic class to manipulate PE files. 5 // This file implements PEImage, a generic class to manipulate PE files.
6 // This file was adapted from GreenBorder's Code. 6 // This file was adapted from GreenBorder's Code.
7 7
8 #include "base/win/pe_image.h" 8 #include "base/win/pe_image.h"
9 9
10 namespace base { 10 namespace base {
11 namespace win { 11 namespace win {
12 12
13 #if defined(_WIN64) && !defined(NACL_WIN64) 13 #if defined(_WIN64) && !defined(NACL_WIN64)
14 // TODO(rvargas): Bug 27218. Make sure this is ok. 14 // TODO(jschuh): crbug.com/167707 Make sure this is ok.
15 #error This code is not tested on x64. Please make sure all the base unit tests\ 15 #pragma message ("Warning: \
16 This code is not tested on x64. Please make sure all the base unit tests\
16 pass before doing any real work. The current unit tests don't test the\ 17 pass before doing any real work. The current unit tests don't test the\
17 differences between 32- and 64-bits implementations. Bugs may slip through.\ 18 differences between 32- and 64-bits implementations. Bugs may slip through.\
18 You need to improve the coverage before continuing. 19 You need to improve the coverage before continuing.")
19 #endif 20 #endif
20 21
21 // Structure to perform imports enumerations. 22 // Structure to perform imports enumerations.
22 struct EnumAllImportsStorage { 23 struct EnumAllImportsStorage {
23 PEImage::EnumImportsFunction callback; 24 PEImage::EnumImportsFunction callback;
24 PVOID cookie; 25 PVOID cookie;
25 }; 26 };
26 27
27 namespace { 28 namespace {
28 29
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 DWORD disk_offset; 562 DWORD disk_offset;
562 563
563 if (!ImageAddrToOnDiskOffset(in_memory, &disk_offset)) 564 if (!ImageAddrToOnDiskOffset(in_memory, &disk_offset))
564 return NULL; 565 return NULL;
565 566
566 return PEImage::RVAToAddr(disk_offset); 567 return PEImage::RVAToAddr(disk_offset);
567 } 568 }
568 569
569 } // namespace win 570 } // namespace win
570 } // namespace base 571 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698