Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: chrome/browser/extensions/api/dial/dial_service.cc

Issue 11669010: Only define ERROR on windows builds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: flip server Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/dial/dial_service.cc
diff --git a/chrome/browser/extensions/api/dial/dial_service.cc b/chrome/browser/extensions/api/dial/dial_service.cc
index 7b30286d987e9c9323fb1e532783bf6ff25b4d40..a18711a9799c6211bb2978491b8d593d63fcc34e 100644
--- a/chrome/browser/extensions/api/dial/dial_service.cc
+++ b/chrome/browser/extensions/api/dial/dial_service.cc
@@ -423,7 +423,7 @@ bool DialServiceImpl::CheckResult(const char* operation, int result) {
if (result < net::OK && result != net::ERR_IO_PENDING) {
CloseSocket();
std::string error_str(net::ErrorToString(result));
- DVLOG(ERROR) << "dial socket error: " << error_str;
+ DVLOG(0) << "dial socket error: " << error_str;
akalin 2012/12/21 23:13:35 i feel like the callers probably did mean DLOG(ERR
mark a. foltz 2013/01/09 07:57:09 DLOG(INFO) is fine for this log line.
FOR_EACH_OBSERVER(Observer, observer_list_, OnError(this, error_str));
return false;
}

Powered by Google App Engine
This is Rietveld 408576698