Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: chrome/browser/extensions/api/dial/dial_service.cc

Issue 11669010: Only define ERROR on windows builds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: flip server Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/dial/dial_service.h" 5 #include "chrome/browser/extensions/api/dial/dial_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 return; 416 return;
417 socket_.reset(); 417 socket_.reset();
418 } 418 }
419 419
420 bool DialServiceImpl::CheckResult(const char* operation, int result) { 420 bool DialServiceImpl::CheckResult(const char* operation, int result) {
421 DCHECK(thread_checker_.CalledOnValidThread()); 421 DCHECK(thread_checker_.CalledOnValidThread());
422 DVLOG(1) << "Operation " << operation << " result " << result; 422 DVLOG(1) << "Operation " << operation << " result " << result;
423 if (result < net::OK && result != net::ERR_IO_PENDING) { 423 if (result < net::OK && result != net::ERR_IO_PENDING) {
424 CloseSocket(); 424 CloseSocket();
425 std::string error_str(net::ErrorToString(result)); 425 std::string error_str(net::ErrorToString(result));
426 DVLOG(ERROR) << "dial socket error: " << error_str; 426 DVLOG(0) << "dial socket error: " << error_str;
akalin 2012/12/21 23:13:35 i feel like the callers probably did mean DLOG(ERR
mark a. foltz 2013/01/09 07:57:09 DLOG(INFO) is fine for this log line.
427 FOR_EACH_OBSERVER(Observer, observer_list_, OnError(this, error_str)); 427 FOR_EACH_OBSERVER(Observer, observer_list_, OnError(this, error_str));
428 return false; 428 return false;
429 } 429 }
430 return true; 430 return true;
431 } 431 }
432 432
433 } // namespace extensions 433 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698