Only define ERROR on windows builds

Only define ERROR on windows builds

This is to stop people accidentally using the ERROR macro for other uses,
e.g. VLOG(ERROR) is not meaningful.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175998

[joth, 2012-12-21 22:50:05]

+OWNERS

[Yoyo Zhou, 2012-12-21 22:54:27]

extensions LGTM

[akalin, 2012-12-21 23:13:35]

lgtm

https://codereview.chromium.org/11669010/diff/9004/chrome/browser/extensions/...
File chrome/browser/extensions/api/dial/dial_service.cc (right):

https://codereview.chromium.org/11669010/diff/9004/chrome/browser/extensions/...
chrome/browser/extensions/api/dial/dial_service.cc:426: DVLOG(0) << "dial socket
error: " << error_str;
i feel like the callers probably did mean DLOG(ERROR)

DVLOG(0) is equivalent to DLOG(INFO), but these seem more like errors.

[joth, 2012-12-21 23:19:24]

On 21 December 2012 15:13, <akalin@chromium.org> wrote:

> lgtm
>
>
> https://codereview.chromium.**org/11669010/diff/9004/chrome/**
>
browser/extensions/api/dial/**dial_service.cc<https://codereview.chromium.org/11669010/diff/9004/chrome/browser/extensions/api/dial/dial_service.cc>
> File chrome/browser/extensions/api/**dial/dial_service.cc (right):
>
> https://codereview.chromium.**org/11669010/diff/9004/chrome/**
>
browser/extensions/api/dial/**dial_service.cc#newcode426<https://codereview.chromium.org/11669010/diff/9004/chrome/browser/extensions/api/dial/dial_service.cc#newcode426>
> chrome/browser/extensions/api/**dial/dial_service.cc:426: DVLOG(0) <<
> "dial socket error: " << error_str;
> i feel like the callers probably did mean DLOG(ERROR)
>
> DVLOG(0) is equivalent to DLOG(INFO), but these seem more like errors.
>
>
ya, I went back and forth on this, and in the end felt it safest to keep
this patch as  a straight no-behavior-change refactor, and let owners
straighten up the meanings themselves rather than have me second guess them
:)

FWIW,  DLOG(ERROR) seems an odd to me. If it's a real important error that
should be seen, why only print it in a debug build?




>
https://codereview.chromium.**org/11669010/<https://codereview.chromium.org/1...
>

[Yoyo Zhou, 2012-12-21 23:21:47]

+mfoltz, if you have comments on dial API

[akalin, 2012-12-22 00:01:58]

> FWIW,  DLOG(ERROR) seems an odd to me. If it's a real important error that
> should be seen, why only print it in a debug build?

Fair enough.  I suppose if it really mattered, someone would have fixed it
already.

[apatrick_chromium, 2012-12-23 13:50:44]

gpu/ stuff LGTM

[joth, 2012-12-26 21:29:59]

+mark for base/
+szym for net/
+cpu for win8/metro_driver

[szym, 2012-12-26 21:33:06]

net LGTM

[cpu_(ooo_6.6-7.5), 2012-12-27 23:07:20]

https://codereview.chromium.org/11669010/diff/9004/base/logging.h
File base/logging.h (right):

https://codereview.chromium.org/11669010/diff/9004/base/logging.h#newcode334
base/logging.h:334: // wingdi.h defines ERROR to be 0. When we call LOG(ERROR),
it gets
so if the workaround is still there for windows, why do we need to modify the
win8 code with "0" ?

[joth, 2012-12-27 23:17:31]

On 2012/12/27 23:07:20, cpu wrote:
> https://codereview.chromium.org/11669010/diff/9004/base/logging.h
> File base/logging.h (right):
> 
> https://codereview.chromium.org/11669010/diff/9004/base/logging.h#newcode334
> base/logging.h:334: // wingdi.h defines ERROR to be 0. When we call
LOG(ERROR),
> it gets
> so if the workaround is still there for windows, why do we need to modify the
> win8 code with "0" ?

Yeah guess I strictly don't need that change to keep things compiling, but it's
totally misleading to say DVLOG(ERROR) (it needs at least INFO level to be seen)
so I thought I'd clean it up while I'm at it. [I found most the violations via a
simple grep]

[cpu_(ooo_6.6-7.5), 2013-01-03 21:34:51]

lgtm on the win8 file

[joth, 2013-01-03 22:06:07]

ping: mark or jar for base/ rubberstamp.

then this is good to go.

[joth, 2013-01-09 02:59:42]

+darin for OWNER approval.
(jar and mark both seem unreachable)

[mark a. foltz, 2013-01-09 07:57:09]

LGTM

Sorry for the late review.

https://codereview.chromium.org/11669010/diff/9004/chrome/browser/extensions/...
File chrome/browser/extensions/api/dial/dial_service.cc (right):

https://codereview.chromium.org/11669010/diff/9004/chrome/browser/extensions/...
chrome/browser/extensions/api/dial/dial_service.cc:426: DVLOG(0) << "dial socket
error: " << error_str;
On 2012/12/21 23:13:35, akalin wrote:
> i feel like the callers probably did mean DLOG(ERROR)
> 
> DVLOG(0) is equivalent to DLOG(INFO), but these seem more like errors.

DLOG(INFO) is fine for this log line.

[darin (slow to review), 2013-01-09 09:20:47]

LGTM

[commit-bot: I haz the power, 2013-01-10 00:03:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joth@chromium.org/11669010/9004

[commit-bot: I haz the power, 2013-01-10 02:41:59]

Change committed as 175998