Issue 11665005: Support scalar lists in array bounds check elimination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11665005: Support scalar lists in array bounds check elimination. (Closed)

Created:
8 years ago by Florian Schneider

Modified:
7 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support scalar lists in array bounds check elimination. This allows to eliminate bounds checks for scalar lists in loops like: for (var i=0; i < a.length; i++) { a[i] } Committed: https://code.google.com/p/dart/source/detail?r=16716

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -15 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	3 chunks	+37 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

https://chromiumcodereview.appspot.com/11665005/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/11665005/diff/1/runtime/vm/intermediate_language.cc#newcode2735 runtime/vm/intermediate_language.cc:2735: case kFloat64ArrayCid: Make sure that LengthOffsetFor can return offset ...

7 years, 11 months ago (2013-01-07 11:47:08 UTC) #3

Florian Schneider

7 years, 11 months ago (2013-01-07 14:24:49 UTC) #4

https://codereview.chromium.org/11665005/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/11665005/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:2735: case kFloat64ArrayCid:
On 2013/01/07 11:47:09, Vyacheslav Egorov (Google) wrote:
> Make sure that LengthOffsetFor can return offset for every array mentioned
here.

Done. Changed LengthOffsetFor to handle the same array classes.

Expand Messages | Collapse Messages