Sync laziness between BuildFunctionInfo and MakeFunctionInfo.

src/compiler.cc

Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index ceac829cf80351d1a8d483b020047cd10a0df706..4d8cb9f7ebd428fbb8b50b93968c65ec3305d3cf 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -511,8 +511,9 @@ static Handle<SharedFunctionInfo> MakeFunctionInfo(CompilationInfo* info) {
   // Only allow non-global compiles for eval.
   ASSERT(info->is_eval() || info->is_global());
   ParsingFlags flags = kNoParsingFlags;
-  if (info->pre_parse_data() != NULL ||
-      String::cast(script->source())->length() > FLAG_min_preparse_length) {
+  if ((info->pre_parse_data() != NULL ||
+      String::cast(script->source())->length() > FLAG_min_preparse_length) &&
+      !isolate->DebuggerHasBreakPoints()) {

[Michael Starzinger, 2013/01/14 15:16:03]

To make this completely consistent with the predicate for the compiler call in
BuildFunctionInfo we would also need to check whether the
LiveEditFunctionTracker is active.

How about we move this whole predicate into a static helper to avoid
duplication? I was thinking of something like ...

static bool DebuggerWantsEagerCompilation(bool allow_lazy_without_ctx) {
  return LiveEditFunctionTracker::IsActive(info.isolate()) ||
         (info.isolate()->DebuggerHasBreakPoints() && !allow_lazy_without_ctx);
}

Of course here we don't know whether lazy compilation without context is
allowed, so that would be set to false here. But we would be able share this
predicate with BuildFunctionInfo.

     flags = kAllowLazy;
   }
   if (!ParserApi::Parse(info, flags)) {