Sync laziness between BuildFunctionInfo and MakeFunctionInfo.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 493 matching lines @@
     }
   }
 
   // Notify debugger
   isolate->debugger()->OnBeforeCompile(script);
 #endif
 
   // Only allow non-global compiles for eval.
   ASSERT(info->is_eval() || info->is_global());
   ParsingFlags flags = kNoParsingFlags;
-  if (info->pre_parse_data() != NULL ||
-      String::cast(script->source())->length() > FLAG_min_preparse_length) {
+  if ((info->pre_parse_data() != NULL ||
+      String::cast(script->source())->length() > FLAG_min_preparse_length) &&
+      !isolate->DebuggerHasBreakPoints()) {

[Michael Starzinger, 2013/01/14 15:16:03]

To make this completely consistent with the predicate for the compiler call in
BuildFunctionInfo we would also need to check whether the
LiveEditFunctionTracker is active.

How about we move this whole predicate into a static helper to avoid
duplication? I was thinking of something like ...

static bool DebuggerWantsEagerCompilation(bool allow_lazy_without_ctx) {
  return LiveEditFunctionTracker::IsActive(info.isolate()) ||
         (info.isolate()->DebuggerHasBreakPoints() && !allow_lazy_without_ctx);
}

Of course here we don't know whether lazy compilation without context is
allowed, so that would be set to false here. But we would be able share this
predicate with BuildFunctionInfo.

     flags = kAllowLazy;
   }
   if (!ParserApi::Parse(info, flags)) {
     return Handle<SharedFunctionInfo>::null();
   }
 
   // Measure how long it takes to do the compilation; only take the
   // rest of the function into account to avoid overlap with the
   // parsing statistics.
   HistogramTimer* rate = info->is_eval()
@@ skipping 584 matching lines @@
     }
   }
 
   GDBJIT(AddCode(Handle<String>(shared->DebugName()),
                  Handle<Script>(info->script()),
                  Handle<Code>(info->code()),
                  info));
 }
 
 } }  // namespace v8::internal