Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4837)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc

Issue 11660016: Move the parsing of "chrome_url_overrides" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc
deleted file mode 100644
index b7d4c0ed8f643c7ca50e7fcf13c49239cd854523..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc
+++ /dev/null
@@ -1,29 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
Yoyo Zhou 2012/12/28 03:59:45 I'd say that this file could also be left in its c
Joe Thomas 2013/01/04 23:36:11 Done.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-
-#include "chrome/common/extensions/extension_manifest_constants.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace errors = extension_manifest_errors;
-
-TEST_F(ExtensionManifestTest, Override) {
- Testcase testcases[] = {
- Testcase("override_newtab_and_history.json", errors::kMultipleOverrides),
- Testcase("override_invalid_page.json", errors::kInvalidChromeURLOverrides)
- };
- RunTestcases(testcases, arraysize(testcases),
- EXPECT_TYPE_ERROR);
-
- scoped_refptr<extensions::Extension> extension;
-
- extension = LoadAndExpectSuccess("override_new_tab.json");
- EXPECT_EQ(extension->url().spec() + "newtab.html",
- extension->GetChromeURLOverrides().find("newtab")->second.spec());
-
- extension = LoadAndExpectSuccess("override_history.json");
- EXPECT_EQ(extension->url().spec() + "history.html",
- extension->GetChromeURLOverrides().find("history")->second.spec());
-}

Powered by Google App Engine
This is Rietveld 408576698