Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc

Issue 11660016: Move the parsing of "chrome_url_overrides" out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
Yoyo Zhou 2012/12/28 03:59:45 I'd say that this file could also be left in its c
Joe Thomas 2013/01/04 23:36:11 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6
7 #include "chrome/common/extensions/extension_manifest_constants.h"
8 #include "testing/gtest/include/gtest/gtest.h"
9
10 namespace errors = extension_manifest_errors;
11
12 TEST_F(ExtensionManifestTest, Override) {
13 Testcase testcases[] = {
14 Testcase("override_newtab_and_history.json", errors::kMultipleOverrides),
15 Testcase("override_invalid_page.json", errors::kInvalidChromeURLOverrides)
16 };
17 RunTestcases(testcases, arraysize(testcases),
18 EXPECT_TYPE_ERROR);
19
20 scoped_refptr<extensions::Extension> extension;
21
22 extension = LoadAndExpectSuccess("override_new_tab.json");
23 EXPECT_EQ(extension->url().spec() + "newtab.html",
24 extension->GetChromeURLOverrides().find("newtab")->second.spec());
25
26 extension = LoadAndExpectSuccess("override_history.json");
27 EXPECT_EQ(extension->url().spec() + "history.html",
28 extension->GetChromeURLOverrides().find("history")->second.spec());
29 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698