[Cleanup] Used scoped pointers in KeyedServiceFactory's SetTestingFactory functions.

chrome/browser/invalidation/profile_invalidation_provider_factory.cc

Index: chrome/browser/invalidation/profile_invalidation_provider_factory.cc
diff --git a/chrome/browser/invalidation/profile_invalidation_provider_factory.cc b/chrome/browser/invalidation/profile_invalidation_provider_factory.cc
index 39b401a685b1ded60dc1749e2e1abc1da85d43c3..4bc6171c777f11255d72363f155f634b971a8263 100644
--- a/chrome/browser/invalidation/profile_invalidation_provider_factory.cc
+++ b/chrome/browser/invalidation/profile_invalidation_provider_factory.cc
@@ -95,7 +95,7 @@ void ProfileInvalidationProviderFactory::RegisterTestingFactory(
 KeyedService* ProfileInvalidationProviderFactory::BuildServiceInstanceFor(

[sky, 2015/06/08 20:18:49]

It seems weird not to change this too. Is there a reason you didn't want to
update BuildServiceInfanceFor to return a scoped_ptr too?

[Ilya Sherman, 2015/06/08 22:11:43]

I'd like to change it, but would prefer to punt that to a separate CL (which
might take a while to author).  Note that this method is overridden from
BrowserContextKeyedServiceFactory.  There are roughly 400 files that override
the same method, so I figured that it made sense to transition the API over one
step at a time.

     content::BrowserContext* context) const {
   if (testing_factory_)
-    return testing_factory_(context);
+    return testing_factory_(context).release();
 
 #if defined(OS_ANDROID)
   return new ProfileInvalidationProvider(scoped_ptr<InvalidationService>(