Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 11647024: Update Linux sandbox tests to pass on Android. (Closed)

Created:
8 years ago by palmer
Modified:
8 years ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@seccomp-2
Visibility:
Public.

Description

Update Linux sandbox tests to pass on Android. BUG=166704 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174116

Patch Set 1 #

Total comments: 1

Patch Set 2 : Guard the Android path_utils.h. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M sandbox/linux/services/broker_process_unittest.cc View 1 2 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jln (very slow on Chromium)
Pair programming LGTM :)
8 years ago (2012-12-20 01:29:54 UTC) #1
jln (very slow on Chromium)
https://chromiumcodereview.appspot.com/11647024/diff/1/sandbox/linux/services/broker_process_unittest.cc File sandbox/linux/services/broker_process_unittest.cc (right): https://chromiumcodereview.appspot.com/11647024/diff/1/sandbox/linux/services/broker_process_unittest.cc#newcode15 sandbox/linux/services/broker_process_unittest.cc:15: #include "base/android/path_utils.h" Erg, it's failing. I guess you need ...
8 years ago (2012-12-20 01:49:30 UTC) #2
palmer
> Erg, it's failing. I guess you need to wrap this if OS_ANDROID after all. ...
8 years ago (2012-12-20 02:00:25 UTC) #3
jln (very slow on Chromium)
On 2012/12/20 02:00:25, Chris P. wrote: > > Erg, it's failing. I guess you need ...
8 years ago (2012-12-20 05:14:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/11647024/5002
8 years ago (2012-12-20 07:42:03 UTC) #5
commit-bot: I haz the power
8 years ago (2012-12-20 07:56:57 UTC) #6
Message was sent while issue was closed.
Change committed as 174116

Powered by Google App Engine
This is Rietveld 408576698