Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: chrome/common/extensions/extension.h

Issue 11644057: Move BrowserAction out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_ungoop_extension_action
Patch Set: Latest master for CQ Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/omnibox/omnibox_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 429bc03237b71f73d8c54422ef92f41b737a2fc2..45f943b8e12d6b038ff56d248486751c8150f525 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -21,7 +21,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/synchronization/lock.h"
#include "base/threading/thread_checker.h"
-#include "chrome/common/extensions/api/extension_action/action_info.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/permissions/api_permission.h"
@@ -51,7 +50,7 @@ class ImageSkia;
FORWARD_DECLARE_TEST(TabStripModelTest, Apps);
namespace extensions {
-
+struct ActionInfo;
class Manifest;
class PermissionSet;
@@ -606,9 +605,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
}
const UserScriptList& content_scripts() const { return content_scripts_; }
const ActionInfo* page_action_info() const { return page_action_info_.get(); }
- const ActionInfo* browser_action_info() const {
- return browser_action_info_.get();
- }
const ActionInfo* system_indicator_info() const {
return system_indicator_info_.get();
}
@@ -959,9 +955,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// The extension's page action, if any.
scoped_ptr<ActionInfo> page_action_info_;
- // The extension's browser action, if any.
- scoped_ptr<ActionInfo> browser_action_info_;
-
// The extension's system indicator, if any.
scoped_ptr<ActionInfo> system_indicator_info_;
« no previous file with comments | « chrome/common/extensions/api/omnibox/omnibox_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698