chrome/common/extensions/api/omnibox/omnibox_handler.cc - Issue 11644057: Move BrowserAction out of Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/omnibox/omnibox_handler.cc

Issue 11644057: Move BrowserAction out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_ungoop_extension_action

Patch Set: Latest master for CQ Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/omnibox/omnibox_handler.cc

diff --git a/chrome/common/extensions/api/omnibox/omnibox_handler.cc b/chrome/common/extensions/api/omnibox/omnibox_handler.cc

index ece5388b51c023dcaaa441a7cf0282c1c273a5e6..287021dd2134f6b0af607fce27752eb430bffe7d 100644

--- a/chrome/common/extensions/api/omnibox/omnibox_handler.cc

+++ b/chrome/common/extensions/api/omnibox/omnibox_handler.cc

@@ -9,6 +9,7 @@

#include "base/utf_string_conversions.h"

#include "base/values.h"

#include "chrome/common/extensions/api/commands/commands_handler.h"

+#include "chrome/common/extensions/api/extension_action/action_info.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

@@ -31,7 +32,7 @@ const std::string& OmniboxInfo::GetKeyword(const Extension* extension) {

// static

bool OmniboxInfo::IsVerboseInstallMessage(const Extension* extension) {

return !GetKeyword(extension).empty() ||

- extension->browser_action_info() ||

+ ActionInfo::GetBrowserActionInfo(extension) ||

(extension->page_action_info() &&

(CommandsInfo::GetPageActionCommand(extension) ||

!extension->page_action_info()->default_icon.empty()));