Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3579)

Unified Diff: chrome/browser/instant/instant_page.h

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_extended_browsertest.cc ('k') | chrome/browser/instant/instant_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_page.h
diff --git a/chrome/browser/instant/instant_page.h b/chrome/browser/instant/instant_page.h
index dbcc08ceb36ac133765a0285e1a98b3e657dd783..f0167c2e2c907f9cfe4d213e8a2992d03560b419 100644
--- a/chrome/browser/instant/instant_page.h
+++ b/chrome/browser/instant/instant_page.h
@@ -77,13 +77,14 @@ class InstantPage : public content::WebContentsObserver {
// strokes.
virtual void StopCapturingKeyStrokes(content::WebContents* contents) = 0;
- // Called when the page wants to navigate to the specified URL. Usually
- // used by the page to navigate to privileged destinations (e.g. chrome://
- // URLs) or to navigate to URLs that are hidden from the page using
- // Restricted IDs (rid in the API).
+ // Called when the page wants to navigate to |url|. Usually used by the
+ // page to navigate to privileged destinations (e.g. chrome:// URLs) or to
+ // navigate to URLs that are hidden from the page using Restricted IDs (rid
+ // in the API).
virtual void NavigateToURL(const content::WebContents* contents,
const GURL& url,
- content::PageTransition transition) = 0;
+ content::PageTransition transition,
+ WindowOpenDisposition disposition) = 0;
// Called when the SearchBox wants to delete a Most Visited item.
virtual void DeleteMostVisitedItem(const GURL& url) = 0;
@@ -216,8 +217,10 @@ class InstantPage : public content::WebContentsObserver {
InstantSizeUnits units);
void OnStartCapturingKeyStrokes(int page_id);
void OnStopCapturingKeyStrokes(int page_id);
- void OnSearchBoxNavigate(int page_id, const GURL& url,
- content::PageTransition transition);
+ void OnSearchBoxNavigate(int page_id,
+ const GURL& url,
+ content::PageTransition transition,
+ WindowOpenDisposition disposition);
void OnDeleteMostVisitedItem(const GURL& url);
void OnUndoMostVisitedDeletion(const GURL& url);
void OnUndoAllMostVisitedDeletions();
« no previous file with comments | « chrome/browser/instant/instant_extended_browsertest.cc ('k') | chrome/browser/instant/instant_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698