Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/instant/instant_page.h

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_INSTANT_INSTANT_PAGE_H_ 5 #ifndef CHROME_BROWSER_INSTANT_INSTANT_PAGE_H_
6 #define CHROME_BROWSER_INSTANT_INSTANT_PAGE_H_ 6 #define CHROME_BROWSER_INSTANT_INSTANT_PAGE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 // strokes. If this call is processed successfully, the omnibox will not 70 // strokes. If this call is processed successfully, the omnibox will not
71 // look focused visibly but any user key strokes will go to the omnibox. 71 // look focused visibly but any user key strokes will go to the omnibox.
72 // Currently, this is implemented by focusing the omnibox invisibly. 72 // Currently, this is implemented by focusing the omnibox invisibly.
73 virtual void StartCapturingKeyStrokes( 73 virtual void StartCapturingKeyStrokes(
74 const content::WebContents* contents) = 0; 74 const content::WebContents* contents) = 0;
75 75
76 // Called when the page wants the omnibox to stop capturing user key 76 // Called when the page wants the omnibox to stop capturing user key
77 // strokes. 77 // strokes.
78 virtual void StopCapturingKeyStrokes(content::WebContents* contents) = 0; 78 virtual void StopCapturingKeyStrokes(content::WebContents* contents) = 0;
79 79
80 // Called when the page wants to navigate to the specified URL. Usually 80 // Called when the page wants to navigate to |url|. Usually used by the
81 // used by the page to navigate to privileged destinations (e.g. chrome:// 81 // page to navigate to privileged destinations (e.g. chrome:// URLs) or to
82 // URLs) or to navigate to URLs that are hidden from the page using 82 // navigate to URLs that are hidden from the page using Restricted IDs (rid
83 // Restricted IDs (rid in the API). 83 // in the API).
84 virtual void NavigateToURL(const content::WebContents* contents, 84 virtual void NavigateToURL(const content::WebContents* contents,
85 const GURL& url, 85 const GURL& url,
86 content::PageTransition transition) = 0; 86 content::PageTransition transition,
87 WindowOpenDisposition disposition) = 0;
87 88
88 // Called when the SearchBox wants to delete a Most Visited item. 89 // Called when the SearchBox wants to delete a Most Visited item.
89 virtual void DeleteMostVisitedItem(const GURL& url) = 0; 90 virtual void DeleteMostVisitedItem(const GURL& url) = 0;
90 91
91 // Called when the SearchBox wants to undo a Most Visited deletion. 92 // Called when the SearchBox wants to undo a Most Visited deletion.
92 virtual void UndoMostVisitedDeletion(const GURL& url) = 0; 93 virtual void UndoMostVisitedDeletion(const GURL& url) = 0;
93 94
94 // Called when the SearchBox wants to undo all Most Visited deletions. 95 // Called when the SearchBox wants to undo all Most Visited deletions.
95 virtual void UndoAllMostVisitedDeletions() = 0; 96 virtual void UndoAllMostVisitedDeletions() = 0;
96 97
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 210
210 void OnSetSuggestions(int page_id, 211 void OnSetSuggestions(int page_id,
211 const std::vector<InstantSuggestion>& suggestions); 212 const std::vector<InstantSuggestion>& suggestions);
212 void OnInstantSupportDetermined(int page_id, bool supports_instant); 213 void OnInstantSupportDetermined(int page_id, bool supports_instant);
213 void OnShowInstantOverlay(int page_id, 214 void OnShowInstantOverlay(int page_id,
214 InstantShownReason reason, 215 InstantShownReason reason,
215 int height, 216 int height,
216 InstantSizeUnits units); 217 InstantSizeUnits units);
217 void OnStartCapturingKeyStrokes(int page_id); 218 void OnStartCapturingKeyStrokes(int page_id);
218 void OnStopCapturingKeyStrokes(int page_id); 219 void OnStopCapturingKeyStrokes(int page_id);
219 void OnSearchBoxNavigate(int page_id, const GURL& url, 220 void OnSearchBoxNavigate(int page_id,
220 content::PageTransition transition); 221 const GURL& url,
222 content::PageTransition transition,
223 WindowOpenDisposition disposition);
221 void OnDeleteMostVisitedItem(const GURL& url); 224 void OnDeleteMostVisitedItem(const GURL& url);
222 void OnUndoMostVisitedDeletion(const GURL& url); 225 void OnUndoMostVisitedDeletion(const GURL& url);
223 void OnUndoAllMostVisitedDeletions(); 226 void OnUndoAllMostVisitedDeletions();
224 227
225 Delegate* const delegate_; 228 Delegate* const delegate_;
226 bool supports_instant_; 229 bool supports_instant_;
227 230
228 DISALLOW_COPY_AND_ASSIGN(InstantPage); 231 DISALLOW_COPY_AND_ASSIGN(InstantPage);
229 }; 232 };
230 233
231 #endif // CHROME_BROWSER_INSTANT_INSTANT_PAGE_H_ 234 #endif // CHROME_BROWSER_INSTANT_INSTANT_PAGE_H_
OLDNEW
« no previous file with comments | « chrome/browser/instant/instant_extended_browsertest.cc ('k') | chrome/browser/instant/instant_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698