Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 11644006: Fix bug where extension popups would not properly receive input focus when (Closed)

Created:
8 years ago by Matt Perry
Modified:
8 years ago
Reviewers:
Yoyo Zhou, sky
CC:
chromium-reviews, Aaron Boodman, tfarina, chromium-apps-reviews_chromium.org, Finnur
Visibility:
Public.

Description

Fix bug where extension popups would not properly receive input focus when first shown. BUG=122352 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173932

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Matt Perry
Yoyo: please review Finnur: FYI, in case you have an opinion on this code
8 years ago (2012-12-18 22:58:51 UTC) #1
Yoyo Zhou
LGTM. No tests?
8 years ago (2012-12-18 23:01:25 UTC) #2
Matt Perry
The only popup-related test is BrowserActionApiTest. BrowserActionPopup, which is disabled due to flakiness :(
8 years ago (2012-12-19 00:46:37 UTC) #3
Yoyo Zhou
On 2012/12/19 00:46:37, Matt Perry wrote: > The only popup-related test is BrowserActionApiTest. BrowserActionPopup, which ...
8 years ago (2012-12-19 00:48:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/11644006/1
8 years ago (2012-12-19 01:05:26 UTC) #5
commit-bot: I haz the power
Presubmit check for 11644006-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-19 01:05:34 UTC) #6
Matt Perry
TBR sky for OWNERS
8 years ago (2012-12-19 01:08:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/11644006/1
8 years ago (2012-12-19 01:22:07 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) browser_tests
8 years ago (2012-12-19 10:20:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/11644006/1
8 years ago (2012-12-19 16:39:50 UTC) #10
commit-bot: I haz the power
8 years ago (2012-12-19 16:40:29 UTC) #11
Message was sent while issue was closed.
Change committed as 173932

Powered by Google App Engine
This is Rietveld 408576698