Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 11644006: Fix bug where extension popups would not properly receive input focus when (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_popup.cc
diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc
index 12461f7d667822982983e4c515f82e3f1a223a45..9b63f6b58f99caac025ac93b39a320b26ebb3286 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.cc
+++ b/chrome/browser/ui/views/extensions/extension_popup.cc
@@ -205,6 +205,10 @@ ExtensionPopup* ExtensionPopup::ShowPopup(
void ExtensionPopup::ShowBubble() {
Show();
+ // Request focus for the View. Without this, the FocusManager gets confused.
+ host()->view()->SetVisible(true);
+ host()->view()->RequestFocus();
+
// Focus on the host contents when the bubble is first shown.
host()->host_contents()->Focus();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698