Issue 11642028: Turn PCH on always for Windows now that 2008 is gone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11642028: Turn PCH on always for Windows now that 2008 is gone (Closed)

Created:
8 years ago by scottmg

Modified:
8 years ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Turn PCH on always for Windows now that 2008 is gone It was already defaulted on for 2010, and as we no longer support 2008 clean this up. This has the side benefit of enabling pch for 2010e, which was slightly incorrect in the previous "enable for 2010" case. R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174228

Patch Set 1 #

Patch Set 2 : preserve behavior for Official #

Total comments: 2

Patch Set 3 : fix comment #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	build/common.gypi	View	1 2	2 chunks	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jói

LGTM with a nit. https://codereview.chromium.org/11642028/diff/2001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11642028/diff/2001/build/common.gypi#newcode510 build/common.gypi:510: # Turn precompiled headers on ...

8 years ago (2012-12-20 13:04:25 UTC) #2

scottmg

https://codereview.chromium.org/11642028/diff/2001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11642028/diff/2001/build/common.gypi#newcode510 build/common.gypi:510: # Turn precompiled headers on by default for VS ...

8 years ago (2012-12-20 18:35:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11642028/6001

8 years ago (2012-12-20 18:35:38 UTC) #4

Message was sent while issue was closed.

Change committed as 174228

Expand Messages | Collapse Messages