Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2474)

Unified Diff: build/common.gypi

Issue 11642028: Turn PCH on always for Windows now that 2008 is gone (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 33d47b14190f447969d520af839ed8c2a392f25f..396fa1d17d4529970c4328cc209900d2e1651673 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -350,19 +350,11 @@
# Use of precompiled headers on Windows.
#
- # This is on by default in VS 2010, but off by default for VS
- # 2008 because of complications that it can cause with our
- # trybots etc.
- #
# This variable may be explicitly set to 1 (enabled) or 0
# (disabled) in ~/.gyp/include.gypi or via the GYP command line.
# This setting will override the default.
#
- # Note that a setting of 1 is probably suitable for most or all
- # Windows developers using VS 2008, since precompiled headers
- # provide a build speedup of 20-25%. There are a couple of
- # small workarounds you may need to use when using VS 2008 (but
- # not 2010), see
+ # See
# http://code.google.com/p/chromium/wiki/WindowsPrecompiledHeaders
# for details.
'chromium_win_pch%': 0,
@@ -515,8 +507,8 @@
'ui_compositor_image_transport%': 0,
}],
- # Turn precompiled headers on by default for VS 2010.
- ['OS=="win" and MSVS_VERSION=="2010" and buildtype!="Official"', {
+ # Turn precompiled headers on by default.
+ ['OS=="win" and buildtype!="Official"', {
'chromium_win_pch%': 1
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698