Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: sandbox/linux/seccomp-bpf/sandbox_bpf.cc

Issue 11639038: ucontext_t support for Android x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ucontext_t support for Android x86. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/linux/seccomp-bpf/sandbox_bpf.cc
diff --git a/sandbox/linux/seccomp-bpf/sandbox_bpf.cc b/sandbox/linux/seccomp-bpf/sandbox_bpf.cc
index 366706f18322a791beff4ab709e75af7a9f2a3c1..2cb61fbfee2b26212fb976ebaface9bb705de300 100644
--- a/sandbox/linux/seccomp-bpf/sandbox_bpf.cc
+++ b/sandbox/linux/seccomp-bpf/sandbox_bpf.cc
@@ -18,8 +18,16 @@
#include "sandbox/linux/seccomp-bpf/verifier.h"
// Android's signal.h doesn't define ucontext etc.
-#if defined(OS_ANDROID) && defined(__arm__)
+#if defined(OS_ANDROID)
jln (very slow on Chromium) 2013/01/08 22:26:09 Can you move most of what's below into a global se
+#if defined(__arm__)
#include "sandbox/linux/services/android_arm_ucontext.h"
+#elif defined(__i386__)
+#include "sandbox/linux/services/android_x86_ucontext.h"
+#elif defined(__mips__)
+#error "Lack ucontext_t definition for mips on Android"
digit1 2013/01/09 09:47:18 If you need a MIPS version, please see https://and
+#else
+#error "Unsupported CPU ABI for Android"
+#endif
#endif
namespace {

Powered by Google App Engine
This is Rietveld 408576698