ucontext_t support for Android x86.

sandbox/linux/seccomp-bpf/sandbox_bpf.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <signal.h>
 #include <sys/prctl.h>
 #include <sys/syscall.h>
 
 #ifndef SECCOMP_BPF_STANDALONE
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #endif
 
 #include "sandbox/linux/seccomp-bpf/codegen.h"
 #include "sandbox/linux/seccomp-bpf/sandbox_bpf.h"
 #include "sandbox/linux/seccomp-bpf/syscall.h"
 #include "sandbox/linux/seccomp-bpf/syscall_iterator.h"
 #include "sandbox/linux/seccomp-bpf/verifier.h"
 
 // Android's signal.h doesn't define ucontext etc.
-#if defined(OS_ANDROID) && defined(__arm__)
+#if defined(OS_ANDROID)

[jln (very slow on Chromium), 2013/01/08 22:26:09]

Can you move most of what's below into a global services/android_ucontext.h ?

+#if defined(__arm__)
 #include "sandbox/linux/services/android_arm_ucontext.h"
+#elif defined(__i386__)
+#include "sandbox/linux/services/android_x86_ucontext.h"
+#elif defined(__mips__)
+#error "Lack ucontext_t definition for mips on Android"

[digit1, 2013/01/09 09:47:18]

If you need a MIPS version, please see
https://android-review.googlesource.com/#/c/38875/4/libc/arch-mips/include/ma...

(this patch was later reverted because it broke something in the internal tree,
but I plan to revive it some time in the future).

+#else
+#error "Unsupported CPU ABI for Android"
+#endif
 #endif
 
 namespace {
 
 void WriteFailedStderrSetupMessage(int out_fd) {
   const char* error_string = strerror(errno);
   static const char msg[] = "You have reproduced a puzzling issue.\n"
                             "Please, report to crbug.com/152530!\n"
                             "Failed to set up stderr: ";
   if (HANDLE_EINTR(write(out_fd, msg, sizeof(msg)-1)) > 0 && error_string &&
@@ skipping 950 matching lines @@
 int Sandbox::proc_fd_                   = -1;
 Sandbox::Evaluators Sandbox::evaluators_;
 Sandbox::Traps *Sandbox::traps_         = NULL;
 Sandbox::TrapIds Sandbox::trap_ids_;
 ErrorCode *Sandbox::trap_array_         = NULL;
 size_t Sandbox::trap_array_size_        = 0;
   bool Sandbox::has_unsafe_traps_       = false;
 Sandbox::Conds Sandbox::conds_;
 
 }  // namespace