Make MediaPlayerEventRouter a PKS to decouple it from ExtensionService

-Rename ExtensionMediaPlayerEventRouter to 
MediaPlayerEventRouter and move to extensions namespace

-Move chrome/browser/chromeos/media/media_player_extension_api
to chrome/browser/chromeos/extensions/media_player_api
and to extension namespace.


Patch from Joe Thomas <mhx348@motorola.com>;.

BUG=159265
TBR=ben@chromium.org for gyp

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175920

[Joe Thomas, 2012-12-20 19:57:39]

Hi Yoyo,

Looks to me like FILE_MANAGER_EXTENSION flag cluttered the patch a lot. Since
the compilation is broken at many places when this flag is OFF, can we just
ignore this flag at this moment? I will update the patch if you feel the same. 

Thanks
Joe

[Yoyo Zhou, 2012-12-20 22:45:20]

Sure, I think we can forget about FILE_MANAGER_EXTENSION. I'm optimistic about
https://code.google.com/p/chromium/issues/detail?id=166934, and besides, if you
can't tell what's broken by compiling with it undefined, you can't be certain
that your #defines are in all the right places anyway.

https://chromiumcodereview.appspot.com/11638024/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/media/media_player.cc (right):

https://chromiumcodereview.appspot.com/11638024/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/media/media_player.cc:123: // How do we handle this
case??
Probably okay to let this notification drop on the floor. (Do nothing.)

https://chromiumcodereview.appspot.com/11638024/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_service.cc (right):

https://chromiumcodereview.appspot.com/11638024/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_service.cc:116: #include
"chrome/browser/chromeos/extensions/media_player_event_router.h"
remove this also

[Joe Thomas, 2012-12-20 23:20:27]

Thanks for the review. Removed the references to the flag
FILE_MANAGER_EXTENSION.

https://chromiumcodereview.appspot.com/11638024/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/media/media_player.cc (right):

https://chromiumcodereview.appspot.com/11638024/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/media/media_player.cc:123: // How do we handle this
case??
On 2012/12/20 22:45:20, Yoyo Zhou wrote:
> Probably okay to let this notification drop on the floor. (Do nothing.)

Done.

https://chromiumcodereview.appspot.com/11638024/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_service.cc (right):

https://chromiumcodereview.appspot.com/11638024/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_service.cc:116: #include
"chrome/browser/chromeos/extensions/media_player_event_router.h"
On 2012/12/20 22:45:20, Yoyo Zhou wrote:
> remove this also

Done.

[Joe Thomas, 2012-12-21 04:40:29]

+sky for chrome/browser/ui/
+mirandac for chrome/browser/profiles/
+kaznacheev for chrome/browser/chromeos/media/

[Yoyo Zhou, 2012-12-21 22:09:13]

LGTM, by the way

[Miranda Callahan, 2013-01-02 14:57:45]

On 2012/12/21 22:09:13, Yoyo Zhou wrote:
> LGTM, by the way

LGTM for profile_dependency_manager change.

[Joe Thomas, 2013-01-02 21:19:07]

I rebased the patch to accommodate the changes that went into
https://chromiumcodereview.appspot.com/11649053/ to avoid creating the new
factory.

Miranda, Yoyo,

Could you please review the patch again?

Thanks

[Miranda Callahan, 2013-01-02 21:24:01]

LGTM again, but no need for my rereview as PDM code didn't change...

On 2013/01/02 21:19:07, Joe Thomas wrote:
> I rebased the patch to accommodate the changes that went into
> https://chromiumcodereview.appspot.com/11649053/ to avoid creating the new
> factory.
> 
> Miranda, Yoyo,
> 
> Could you please review the patch again?
> 
> Thanks

[Yoyo Zhou, 2013-01-02 22:00:23]

another LGTM

[Joe Thomas, 2013-01-03 22:29:22]

@Sky, Vladislav Kaznacheev,

Ping. Could you please take a look at the changes. Thanks.

[sky, 2013-01-07 17:14:11]

c/b/ui/ash LGTM

[Vladislav Kaznacheev, 2013-01-09 08:58:00]

LGTM

[commit-bot: I haz the power, 2013-01-09 20:14:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/MHX348@motorola.com/11638024/31001

[commit-bot: I haz the power, 2013-01-09 23:27:12]

Change committed as 175920