chrome/browser/chromeos/media/media_player.cc - Issue 11638024: Make MediaPlayerEventRouter a PKS to decouple it from ExtensionService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/media/media_player.cc

Issue 11638024: Make MediaPlayerEventRouter a PKS to decouple it from ExtensionService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch rebased Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/media_player_event_router.cc ('k') | chrome/browser/chromeos/media/media_player_extension_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/media/media_player.cc

diff --git a/chrome/browser/chromeos/media/media_player.cc b/chrome/browser/chromeos/media/media_player.cc

index 5306e6d97c2d54816f03f4015869ae5e47f261d2..e162c07931cd616823e871dd4f515b3b39ac7e74 100644

--- a/chrome/browser/chromeos/media/media_player.cc

+++ b/chrome/browser/chromeos/media/media_player.cc

@@ -9,6 +9,7 @@

#include "ash/shell.h"

#include "base/bind.h"

#include "chrome/browser/chromeos/extensions/file_manager_util.h"

+#include "chrome/browser/chromeos/extensions/media_player_api.h"

#include "chrome/browser/chromeos/extensions/media_player_event_router.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

@@ -110,7 +111,11 @@ void MediaPlayer::SetPlaylistPosition(int position) {

}

void MediaPlayer::NotifyPlaylistChanged() {

- ExtensionMediaPlayerEventRouter::GetInstance()->NotifyPlaylistChanged();

+ Browser* browser = GetBrowser();

+ if (browser) {

+ extensions::MediaPlayerAPI::Get(browser->profile())->

+ media_player_event_router()->NotifyPlaylistChanged();

+ }

}

void MediaPlayer::PopupMediaPlayer() {