Consolidate [BrowserAction,PageAction,ScriptBadge]API into ExtensionActionAPI

Consolidate [BrowserAction,PageAction,ScriptBadge]API into ExtensionActionAPI

This CL follows https://chromiumcodereview.appspot.com/11588004/

BUG=159265
TBR=ben@chromium.org,mirandac@chromium.org
(ben: gypi changes, mirandac: rename in c/b/p/profile_dependency_manager)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178184

[Yoyo Zhou, 2012-12-19 23:30:52]

Cool, this isn't actually quite what I had in mind, but it's still well below
the threshold of there being too much to understand in one file. LGTM with nits.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:614: //
PageActionFunction
Comment here that this is deprecated.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:684: //
ScriptBadgeGetAttentionFunction
Put this above the deprecated code.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/extension_action/extension_action_api.h
(right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.h:191: //
browserAction.* aliases for supported browserActions APIs.
nit: browserAction

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.h:286: //
Base class for deprecated page actions APIs
Put this whole block at the bottom of the file.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.h:319: //
pageAction.* aliases for supported extensionActions APIs.
extensionAction -> pageAction

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File
chrome/browser/extensions/api/extension_action/extension_action_api_constants.h
(right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api_constants.h:5:
// Constants used for the Extension Action API.
I would leave this file alone if it's only being used for the deprecated page
actions API.

P.S. I filed https://code.google.com/p/chromium/issues/detail?id=166959 for
deleting this code, as it bothers me that it's still around every time I see it.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/extension_function_registry.cc (right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/extension_function_registry.cc:116:
RegisterFunction<extensions::EnablePageActionFunction>();
Leave these names as they were before - they're in the weird pageActions
namespace - so we don't forget that they are misfits.

[Devlin, 2012-12-20 19:43:20]

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:614: //
PageActionFunction
On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> Comment here that this is deprecated.

Done.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:684: //
ScriptBadgeGetAttentionFunction
On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> Put this above the deprecated code.

Done.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/extension_action/extension_action_api.h
(right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.h:191: //
browserAction.* aliases for supported browserActions APIs.
On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> nit: browserAction

Done.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.h:286: //
Base class for deprecated page actions APIs
On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> Put this whole block at the bottom of the file.

Done.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.h:319: //
pageAction.* aliases for supported extensionActions APIs.
On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> extensionAction -> pageAction

Done.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File
chrome/browser/extensions/api/extension_action/extension_action_api_constants.h
(right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api_constants.h:5:
// Constants used for the Extension Action API.
On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> I would leave this file alone if it's only being used for the deprecated page
> actions API.
> 
> P.S. I filed https://code.google.com/p/chromium/issues/detail?id=166959 for
> deleting this code, as it bothers me that it's still around every time I see
it.

Done. And cool that we can rid of the deprecated code. If no one's got dibs on
the it, I can take it out, since I'm working in here anyway. :)

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/extension_function_registry.cc (right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/extension_function_registry.cc:116:
RegisterFunction<extensions::EnablePageActionFunction>();
On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> Leave these names as they were before - they're in the weird pageActions
> namespace - so we don't forget that they are misfits.

Done.

[Yoyo Zhou, 2013-01-02 21:56:04]

additional nits. Normally though if I LGTMed the earlier patchset it means you
don't need another review from me.

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/extension_action/extension_action_api.h
(right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.h:286: //
Base class for deprecated page actions APIs
On 2012/12/20 19:43:20, D Cronin wrote:
> On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> > Put this whole block at the bottom of the file.
> 
> Done.

The deprecated pageActions should below the non-deprecated pageAction here. (The
order should be the same in the cc file.)

https://codereview.chromium.org/11638022/diff/4006/chrome/browser/extensions/...
File chrome/browser/extensions/browser_event_router.cc (right):

https://codereview.chromium.org/11638022/diff/4006/chrome/browser/extensions/...
chrome/browser/extensions/browser_event_router.cc:33: namespace
extension_action_keys = extension_page_actions_api_constants;
I think this should also go back to being page_action_keys, or rather
page_actions_keys.

[Devlin, 2013-01-16 21:07:31]

+mirandac for c/b/profiles/

On 2013/01/02 21:56:04, Yoyo Zhou wrote:
> additional nits. Normally though if I LGTMed the earlier patchset it means you
> don't need another review from me.
> 

I was waiting for the prerequisite
https://chromiumcodereview.appspot.com/11588004/ to go in before I sent this one
through. :)

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
File chrome/browser/extensions/api/extension_action/extension_action_api.h
(right):

https://codereview.chromium.org/11638022/diff/2001/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/extension_action_api.h:286: //
Base class for deprecated page actions APIs
On 2013/01/02 21:56:05, Yoyo Zhou wrote:
> On 2012/12/20 19:43:20, D Cronin wrote:
> > On 2012/12/19 23:30:52, Yoyo Zhou wrote:
> > > Put this whole block at the bottom of the file.
> > 
> > Done.
> 
> The deprecated pageActions should below the non-deprecated pageAction here.
(The
> order should be the same in the cc file.)

Done.

https://codereview.chromium.org/11638022/diff/4006/chrome/browser/extensions/...
File chrome/browser/extensions/browser_event_router.cc (right):

https://codereview.chromium.org/11638022/diff/4006/chrome/browser/extensions/...
chrome/browser/extensions/browser_event_router.cc:33: namespace
extension_action_keys = extension_page_actions_api_constants;
On 2013/01/02 21:56:05, Yoyo Zhou wrote:
> I think this should also go back to being page_action_keys, or rather
> page_actions_keys.

Done.

[commit-bot: I haz the power, 2013-01-22 22:55:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/11638022/4...

[commit-bot: I haz the power, 2013-01-23 00:47:46]

Change committed as 178184