Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11637053: sync: Start moving away from PREV_ID and NEXT_ID (Closed)

Created:
8 years ago by rlarocque
Modified:
7 years, 11 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

sync: Start moving away from PREV_ID and NEXT_ID This change replaces serveral instances of Get(PREV_ID) and Get(NEXT_ID) with calls to the newly introduced GetPredecessorId() and GetSuccessorId(). This is done in anticipation of the change that will remove PREV_ID and NEXT_ID entirely. By making this change in advance, that patch will be smaller and easier to review. BUG=145412, 126505 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175599

Patch Set 1 #

Patch Set 2 : Convert more instances #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -38 lines) Patch
M sync/engine/build_commit_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/conflict_resolver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/engine/get_commit_ids_command.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/engine/process_commit_response_command_unittest.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M sync/engine/syncer_unittest.cc View 1 3 chunks +9 lines, -11 lines 0 comments Download
M sync/engine/syncer_util.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M sync/internal_api/base_node.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/change_reorder_buffer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/write_node.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/entry.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M sync/syncable/entry.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M sync/syncable/mutable_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/nigori_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/syncable_util.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rlarocque
This is another change broken off of https://codereview.chromium.org/11636006/. Please review.
8 years ago (2012-12-21 18:57:03 UTC) #1
rlarocque
Ping.
7 years, 11 months ago (2013-01-07 23:45:16 UTC) #2
Nicolas Zea
lgtm
7 years, 11 months ago (2013-01-08 00:07:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/11637053/6001
7 years, 11 months ago (2013-01-08 00:21:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/11637053/6001
7 years, 11 months ago (2013-01-08 18:49:35 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:50:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/11637053/6001
7 years, 11 months ago (2013-01-08 19:06:07 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 19:08:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/11637053/6001
7 years, 11 months ago (2013-01-08 19:48:57 UTC) #9
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 22:17:51 UTC) #10
Message was sent while issue was closed. 
Change committed as 175599

Powered by Google App Engine
This is Rietveld 408576698