Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: sync/engine/syncer_unittest.cc

Issue 11637053: sync: Start moving away from PREV_ID and NEXT_ID (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/process_commit_response_command_unittest.cc ('k') | sync/engine/syncer_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/syncer_unittest.cc
diff --git a/sync/engine/syncer_unittest.cc b/sync/engine/syncer_unittest.cc
index 2bfcdf814288ff76205e672d451a61963938d3d0..7fef4f4dfe8a194ce29e010e68b66223d24c983b 100644
--- a/sync/engine/syncer_unittest.cc
+++ b/sync/engine/syncer_unittest.cc
@@ -90,10 +90,8 @@ using syncable::IS_UNAPPLIED_UPDATE;
using syncable::IS_UNSYNCED;
using syncable::META_HANDLE;
using syncable::MTIME;
-using syncable::NEXT_ID;
using syncable::NON_UNIQUE_NAME;
using syncable::PARENT_ID;
-using syncable::PREV_ID;
using syncable::BASE_SERVER_SPECIFICS;
using syncable::SERVER_IS_DEL;
using syncable::SERVER_PARENT_ID;
@@ -4509,14 +4507,14 @@ class SyncerPositionUpdateTest : public SyncerTest {
Id id = i->second;
Entry entry_with_id(&trans, GET_BY_ID, id);
EXPECT_TRUE(entry_with_id.good());
- EXPECT_EQ(prev_id, entry_with_id.Get(PREV_ID));
+ EXPECT_EQ(prev_id, entry_with_id.GetPredecessorId());
EXPECT_EQ(
i->first,
NodeOrdinalToInt64(entry_with_id.Get(SERVER_ORDINAL_IN_PARENT)));
if (next == position_map_.end()) {
- EXPECT_EQ(Id(), entry_with_id.Get(NEXT_ID));
+ EXPECT_EQ(Id(), entry_with_id.GetSuccessorId());
} else {
- EXPECT_EQ(next->second, entry_with_id.Get(NEXT_ID));
+ EXPECT_EQ(next->second, entry_with_id.GetSuccessorId());
next++;
}
prev_id = id;
@@ -4636,12 +4634,12 @@ class SyncerPositionTiebreakingTest : public SyncerTest {
EXPECT_TRUE(low.good());
EXPECT_TRUE(mid.good());
EXPECT_TRUE(high.good());
- EXPECT_TRUE(low.Get(PREV_ID) == null_id);
- EXPECT_TRUE(mid.Get(PREV_ID) == low_id_);
- EXPECT_TRUE(high.Get(PREV_ID) == mid_id_);
- EXPECT_TRUE(high.Get(NEXT_ID) == null_id);
- EXPECT_TRUE(mid.Get(NEXT_ID) == high_id_);
- EXPECT_TRUE(low.Get(NEXT_ID) == mid_id_);
+ EXPECT_TRUE(low.GetPredecessorId() == null_id);
+ EXPECT_TRUE(mid.GetPredecessorId() == low_id_);
+ EXPECT_TRUE(high.GetPredecessorId() == mid_id_);
+ EXPECT_TRUE(high.GetSuccessorId() == null_id);
+ EXPECT_TRUE(mid.GetSuccessorId() == high_id_);
+ EXPECT_TRUE(low.GetSuccessorId() == mid_id_);
}
protected:
« no previous file with comments | « sync/engine/process_commit_response_command_unittest.cc ('k') | sync/engine/syncer_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698