Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4105)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller.cc

Issue 11636040: AutofillPopupController clarifications + simplifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: relative patchset Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller.cc b/chrome/browser/ui/autofill/autofill_dialog_controller.cc
index ecb1335f90631541f7b535234f600a700f78db27..04d8b0a2ebb6a369be594e3b3be82f789f813db3 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller.cc
@@ -400,16 +400,15 @@ void AutofillDialogController::SelectAutofillSuggestion(int unique_id) {
// TODO(estade): implement.
}
-bool AutofillDialogController::DidAcceptAutofillSuggestion(
+void AutofillDialogController::DidAcceptAutofillSuggestion(
const string16& value,
- int unique_id,
- unsigned index) {
+ int unique_id) {
const PersonalDataManager::GUIDPair& pair = popup_guids_[unique_id];
// TODO(estade): need to use the variant, |pair.second|.
AutofillProfile* profile = GetManager()->GetProfileByGUID(pair.first);
// TODO(estade): we shouldn't let this happen.
if (!profile)
- return false;
+ return;
// TODO(estade): implement for all sections.
FillInputFromFormGroup(profile, &requested_billing_fields_);
@@ -418,7 +417,6 @@ bool AutofillDialogController::DidAcceptAutofillSuggestion(
// TODO(estade): not sure why it's necessary to do this explicitly.
popup_controller_->Hide();
ControllerDestroyed();
- return true;
}
void AutofillDialogController::RemoveAutocompleteEntry(const string16& value) {

Powered by Google App Engine
This is Rietveld 408576698